user register without code doesn't work when code is optional - PHP Fatal error: Cannot break/continue 1 level [#2183913]

Hi,

i need to use the rules integration but the 7.x-1.1 version doesn't support the tags comparaison.

The dev version fix this issue (data comparaison) but a new issue appears.
The registration code has to be in my case is optional : (user can register without code. The code only grant new role)
My goals in rules is to add the term associated to the registration code vocabulary to the user account.

The rules works very well but :

With the optional parameter set, when a user try to register without code => blank page : impossible to register.

Does anyone has an idea to fix-it ASAP or tell me how to fix it ?

best regards

Comments

Comment #1

dsivori CreditAttribution: dsivori commented 31 January 2014 at 13:53

Status:

Active

» Needs work

Comment #2

HongPong CreditAttribution: HongPong commented 4 March 2014 at 01:19

Title:

user register without code doesn't work when code is optional

» user register without code doesn't work when code is optional - PHP Fatal error: Cannot break/continue 1 level

Definitely hit this . had
PHP Fatal error: Cannot break/continue 1 level in /sites/all/modules/regcode/regcode.module on line 199

function regcode_user_insert(&$edit, $account) {
  if (empty($edit['regcode'])) {
    continue;
  }

re here http://us2.php.net/continue
I think a continue statement cannot be used in an If statement without breaking things, it's more to be used in while statements.

Comment #3

nithinkolekar CreditAttribution: nithinkolekar commented 19 February 2015 at 08:27

same here with latest dev..

Comment #4

jlenni CreditAttribution: jlenni commented 8 April 2015 at 08:54

same issue with latest version 1.2. Just use return instead of continue should do the trick

Comment #5

8 April 2015 at 10:22

Ayesh committed 45540b9 on 7.x-1.x

Issue #2183913: user register without code doesn't work when code is...

Comment #6

Ayesh CreditAttribution: Ayesh commented 8 April 2015 at 10:25

Thanks everyone!
This issue was also mentioned in #2446157: SA-CONTRIB-2015-065 - Fix comment 14. This 1.2 version is purely a security release, and I'm working on both 1.x-dev and 2.x-dev branches to fix the remaining issues as soon as possible.

This is fixed in current latest 1.x-dev version, and a 1.3 version will be released soon with some other bug fixes.