When using modernizr.min.js in sites/all/libraries, path does not include filename and results in 404 [#2184717]

In modernizr.module in the dev version, if you try loading it from libraries with the name modernizr.min.js, you get a 404. That is because in this line:

$version_agnostic_path = file_exists($path .'/modernizr.min.js') ? $path : FALSE;

file_exists() finds the file, but then $version_agnostic_path is set to just $path, without the filename concatenated.

I'll submit a patch with a fix, it should look like this to properly load the file:

$version_agnostic_path = file_exists($path .'/modernizr.min.js') ? $path .'/modernizr.min.js' : FALSE;

Comment	File	Size	Author
#2	modernizr-file-404-2184717-2.patch	1.62 KB	TravisCarden
#2
#1	modernizr-file-404-2184717-553729.patch	1.05 KB	sarahjean
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

sarahjean CreditAttribution: sarahjean commented 29 January 2014 at 19:32

File	Size
modernizr-file-404-2184717-553729.patch	1.05 KB

Comment #2

TravisCarden CreditAttribution: TravisCarden commented 29 January 2014 at 20:45

Assigned:	sarahjean	» Unassigned
Status:	Active	» Needs review

File	Size
modernizr-file-404-2184717-2.patch	1.62 KB

Here's a backport of the patch against 6.x-1.0, so anyone can use this in a Drush make file or anything if they're running the latest stable release. (@sarahjean's patch can be committed right to the dev version.)

Comment #3

rupl

he/him

English

CreditAttribution: rupl commented 31 January 2014 at 00:22

Thanks for reporting the issue!

I'll be honest, I haven't touched D6 in years. If you can get people to test this all the way up to RTBC I'll commit it.

Comment #4

sarahjean CreditAttribution: sarahjean commented 3 February 2014 at 23:45

Thanks, I know its not a priority with d8 about to come out!

Comment #5

nickfitz CreditAttribution: nickfitz commented 4 February 2014 at 14:53

This patch actually fixed a huge issue for me. I tested it and everything worked as expected. Thanks!

Comment #6

rupl

he/him

English

CreditAttribution: rupl commented 4 February 2014 at 20:39

Hi nickfitz, since you tested the patch and confirmed it is working, could I ask that you set this as RTBC? I'll commit it and make a new release for your effort ;)