Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hi, are there any plans to port the module to D8?
Thanks.
Comment | File | Size | Author |
---|---|---|---|
#6 | 2189179-r4032login-8.x-3.patch | 22.28 KB | bdone |
Comments
Comment #1
bdone CreditAttribution: bdone commentedwith approval of @deekayen, i'm going to take a pass at an upgrade of r4032login to 8.x.
Comment #2
bdone CreditAttribution: bdone commentedreally learned a lot about symfony and d8 from this upgrade!
i'm attaching what i've got so far. this is basically altering the AccessSubscriber service, so r4032login can handle its own 403 exceptions. missing still is...
* exception handling from AccessDeniedHttpException, namely watchdog logs
* rendering of UserLoginForm for match_noredirect_pages config
Comment #3
bdone CreditAttribution: bdone commentedComment #4
bdone CreditAttribution: bdone commentedper suggestions by @damiankloip in IRC, replacing the AccessSubscriber seems overkill. i'll try only listening to the EXCEPTION event in the subscriber instead.
Comment #5
bdone CreditAttribution: bdone commentedeliminating the altering of AccessSubscriber, this is much simpler.
Comment #6
bdone CreditAttribution: bdone commenteda few more updates including...
* configuration factory argument in subscriber service
* form validation for r4032login paths
* missing AccessDeniedHttpException dependecy
* Reordered default_redirect_code mappings
* replaced collapsible fieldset with HTML5 details element
* dropped unused page.403 config
* removed uneeded DestructableInterface and destroy method
Comment #7
bdone CreditAttribution: bdone commented@deekayen has added me as a maintainer, so i've pushed my work so far up to the 8.x-1.x branch. i'll update the version and make some follow up issues once 8.x gets listed here.
Comment #8
deekayen CreditAttribution: deekayen commentedI tested #6 tonight and all the basic functionality from 6.x-1.x worked.
Comment #9
bdone CreditAttribution: bdone commentedComment #10
damiankloip CreditAttribution: damiankloip commentedYou can inject the urlGenerator here too. Other than that - looking pretty good!
Comment #11
bdone CreditAttribution: bdone commentedthanks @damiankloip. i've added a task for this in #2210717: Inject the urlGenerator in R4032LoginSubscriber.
Comment #12
bdone CreditAttribution: bdone commentedI've committed and pushed the new 8.x branch.