Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I'm not exactly sure if I'm getting this error when I access the website with my iPhone or when CRONjob is executed via server-side (which seems to be what triggers it), but this is showing up on my admin/reports/dblog:
Notice: Undefined index: HTTP_USER_AGENT in phone_field_formatter_view() (line 205 of /home/storage/6/8a/ef/site1372096455/public_html/sites/all/modules/phone/phone.module).
Does anyone know how to solve this?
Comment | File | Size | Author |
---|---|---|---|
#5 | interdiff.txt | 629 bytes | dpovshed |
#3 | phone-7.x-1.0-beta1-2189501-3.patch | 576 bytes | dpovshed |
#1 | phone-7.x-1.0-beta1-2189501.patch | 859 bytes | gfed |
Comments
Comment #1
gfed CreditAttribution: gfed commentedThis small patch checks first if HTTP_USER_AGENT is set.
Comment #2
1kenthomas CreditAttribution: 1kenthomas as a volunteer and commentedWhat do we need to do to get this committed to a release? :) Thanks.
Comment #3
dpovshed CreditAttribution: dpovshed as a volunteer and at Drupal Ukraine Community commented@1kenthomas , to move issue forward after patch is provided you need to change status "need work".
Without that, patches may not be reviewed. I just spotted this issue having similar problem in my site.
So, I did a review of patch from comment #1 - and it just was not applied. :)
I rewrite it without a header information (and with additional parentesis for readability) and attached to this message.
Basically fix is fine!
Comment #4
dpovshed CreditAttribution: dpovshed as a volunteer and at Drupal Ukraine Community commentedComment #5
dpovshed CreditAttribution: dpovshed as a volunteer and at Drupal Ukraine Community commentedSorry, interdiff should be in plain text - updating.
Comment #6
tmin CreditAttribution: tmin commentedSeems to be working without issues for me.
Comment #7
jrbThis patch does fix the notice, but this code to check the device should be removed entirely per the issue here #2627596: iPhone renders phone numbers differently than every other device.
Quoting that issue:
People looking to fix this notice should use the patch here: #2627596-2: iPhone renders phone numbers differently than every other device.
Not sure what the status of this issue should be, but it's not RTBC.