I have extra columns in my csv that are not part of my source migration. If data in those unused columns is updated it causes my row to get updated while running an import with track_changes => 1. I would assume that any data not in $this->csvcolumns() should not have any effect on my migration. I will work on a patch.

CommentFileSizeAuthor
#1 migrate-remove-unused-columns-from-row-2191335-1.patch604 bytesbriand44
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

briand44’s picture

briand44 CreditAttribution: briand44 commented
Status: Active » Needs review
FileSize
migrate-remove-unused-columns-from-row-2191335-1.patch604 bytes

Not sure if this is correct but here is a patch.

13rac1’s picture

13rac1 CreditAttribution: 13rac1 commented
Status: Needs review » Reviewed & tested by the community

Applies cleanly. Simple patch. Makes sense. Local automated tests run, but I don't have CSV migration to test further. One line patch though, so RTBC.

  • Commit e018cf9 on 7.x-2.x authored by briand44, committed by mikeryan: 
    Issue #2191335 by briand44: Remove unused columns from CSV source row
mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan commented
Status: Reviewed & tested by the community » Fixed

Looks eminently sensible - committed, thanks!

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan commented
Issue tags: +Migrate 2.6

Tagging as 2.6.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.