Base table or view not found

While debugging a failing unit test, I added some error logging which triggered the following Internal server error rather than logging anything:


An AJAX HTTP error occurred. HTTP Result Code: 500 Debugging information follows. Path: /batch?id=166&op=do StatusText: error ResponseText: PDOException: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'drupal-d7.simpletest616887simpletest' doesn't exist: INSERT INTO {simpletest} (test_id, test_class, status, message, message_group, function, line, file) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3, :db_insert_placeholder_4, :db_insert_placeholder_5, :db_insert_placeholder_6, :db_insert_placeholder_7); Array ( [:db_insert_placeholder_0] => 4 [:db_insert_placeholder_1] => DatabaseSelectTestCase [:db_insert_placeholder_2] => fail [:db_insert_placeholder_3] => [11-Feb-2014 16:18:15] array ( [:db_insert_placeholder_4] => Fatal error [:db_insert_placeholder_5] => Unknown [:db_insert_placeholder_6] => 0 [:db_insert_placeholder_7] => Unknown ) in DrupalTestCase::insertAssert() (line 210 of modules/simpletest/drupal_web_test_case.php).


The problem appears to be that simpletest_log_read is called while the test database is active, so an attempt is made to log the error into the simpletest table (which doesn't exist) in the test database, rather than the simpletest table (which does exist) in the parent Drupal database.

The attached patch moves the simpltest_log_read() call and the file_unmanaged_delete_recursive() call to after the main Drupal database is restored as the active database.