Disqus doesn't list the Libraries module as a dependency, but it is clearly using one of its functions (libraries_detect()). A dependency needs to get added to the info file for the Libraries module version 2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

slashrsm’s picture

Libraries module is only needed in some cases. It is not a hard dependency as such.

azarzag’s picture

I see your point. However, for those cases that it is required and the Libraries module (version 2) is not installed, it crashes the site.

slashrsm’s picture

Status: Active » Needs review
FileSize
2 KB

How does this look like?

CriticalBlast’s picture

1. Is this patch a fix for the configuration error that occurs with this module that reads:

Fatal error: Call to undefined function libraries_detect() in /home/(my account)/public_html/sites/all/modules/disqus/disqus.admin.inc on line 112

2. If so, how do I implement this patch? Just overwrite the bit in the disqus.admin.inc file?

slashrsm’s picture

DamienMcKenna’s picture

Version: 7.x-1.10 » 7.x-1.x-dev
FileSize
1.27 KB

Rerolled.

DamienMcKenna’s picture

Some of the logic in disqus.admin.inc seemed unnecessarily complicated, so does this work?