Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Disqus doesn't list the Libraries module as a dependency, but it is clearly using one of its functions (libraries_detect()). A dependency needs to get added to the info file for the Libraries module version 2
Comment | File | Size | Author |
---|---|---|---|
#7 | disqus-n2193909-7.patch | 1.42 KB | DamienMcKenna |
| |||
#6 | disqus-n2193909-6.patch | 1.27 KB | DamienMcKenna |
#3 | 2193909_3.patch | 2 KB | slashrsm |
Comments
Comment #1
slashrsm CreditAttribution: slashrsm commentedLibraries module is only needed in some cases. It is not a hard dependency as such.
Comment #2
azarzag CreditAttribution: azarzag commentedI see your point. However, for those cases that it is required and the Libraries module (version 2) is not installed, it crashes the site.
Comment #3
slashrsm CreditAttribution: slashrsm commentedHow does this look like?
Comment #4
CriticalBlast CreditAttribution: CriticalBlast commented1. Is this patch a fix for the configuration error that occurs with this module that reads:
Fatal error: Call to undefined function libraries_detect() in /home/(my account)/public_html/sites/all/modules/disqus/disqus.admin.inc on line 112
2. If so, how do I implement this patch? Just overwrite the bit in the disqus.admin.inc file?
Comment #5
slashrsm CreditAttribution: slashrsm commented1. Yes.
2. https://www.drupal.org/patch/apply
Comment #6
DamienMcKennaRerolled.
Comment #7
DamienMcKennaSome of the logic in disqus.admin.inc seemed unnecessarily complicated, so does this work?