Can't add new data source [#2195435]

When adding new data source in from version 7.x-4.x (dev and alpha) (admin/config/content/forena/data/add), it doesn't submit the data to database. After linking back to admin/config/content/forena/data it won't show up.

Before I've tried version 7.x-3.14 and there is no problem.

Comments

Comment #1

hgkris CreditAttribution: hgkris commented 13 February 2014 at 14:27

Sorry I still haven't looked how to submit a patch.

Seems the problem is in the code forena.admin.inc
Line 1199

Seems to be code missing

  $form['save'] = array(
    '#type' => 'submit',
    '#value' => t('Save'),
  );

to and it works again.

  $form['save'] = array(
    '#type' => 'submit',
    '#value' => t('Save'),
    '#submit' => array('forena_data_settings_save'),
  );

Comment #2

metzlerd CreditAttribution: metzlerd commented 16 February 2014 at 22:57

Yep, Sorry for the bug. I will fix this as soon as I can in the dev snapshot. FYI: I wanted to warn you a bit against using the dev snapshot for 7.x-4.x at this time. I try to push out alpha releases as I get new functionality developed, but know that user interface for forena is undergoing heavy modifications right now. If you are building reports with the gui tools, you may encounter significant bugs here. In the end I think this will be a pretty good improvement, but it is pretty rough right now. I would definitely avoid dev snapshots in any kind of production environment. I try and do some testing before rolling the alpha release. In particular the next alpa release will have very significant user interface changes. Here's hoping that you like them ;)