Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Updated: Comment #N
Problem/Motivation
cache.inc now only contains cache() and cache_invalidate_tags() these should be removed as people should be using Cache::invalidateTags() or \Drupal::cache() instead. So we can remove something we include all the time when we don't need to.
Proposed resolution
Remove the cache.inc file, which will in turn remove the deprecated functions mentioned above.
Remaining tasks
User interface changes
None
API changes
Removal of cache() and cache_invalidate_tags() functions.
Comment | File | Size | Author |
---|---|---|---|
#10 | interdiff-2198339.txt | 1017 bytes | longwave |
#10 | 2198339-remove-cache-inc-10.patch | 3.79 KB | longwave |
Comments
Comment #1
BerdirSee also #2177461: Refactor page caching into a service, which kills some of the stuff in cache.inc and removed the left-over code in bootstrap.inc I think.
Comment #2
damiankloip CreditAttribution: damiankloip commentedDefinitely related. Not sure completely though - cache.inc currently only contains cache() and cache_invalidate_tags() functions. Or are you just referencing that issue as one that has removed those things to do with page caching?
Comment #3
damiankloip CreditAttribution: damiankloip commentedComment #4
damiankloip CreditAttribution: damiankloip commentedRemoving the lines including cache.inc in the patch also helps.
Comment #6
BerdirGreat.
Comment #7
webchickLooks like the change notice at https://drupal.org/node/1272696 covers the functions removed here, sooo...
Committed and pushed to 8.x. Thanks!
Comment #8
webchickSorry, nevermind. This broke HEAD because a new instances of cache() was added in the meantime. :\ Reverted.
Comment #9
longwaveComment #10
longwaveOops.
Comment #12
tstoecklerLooks good!
Comment #13
alexpottCommitted cb566fa and pushed to 8.x. Thanks!
Can we add the removal of this file to the relevant change notice.