Updated: Comment #N

Problem/Motivation

cache.inc now only contains cache() and cache_invalidate_tags() these should be removed as people should be using Cache::invalidateTags() or \Drupal::cache() instead. So we can remove something we include all the time when we don't need to.

Proposed resolution

Remove the cache.inc file, which will in turn remove the deprecated functions mentioned above.

Remaining tasks

User interface changes

None

API changes

Removal of cache() and cache_invalidate_tags() functions.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir’s picture

See also #2177461: Refactor page caching into a service, which kills some of the stuff in cache.inc and removed the left-over code in bootstrap.inc I think.

damiankloip’s picture

Definitely related. Not sure completely though - cache.inc currently only contains cache() and cache_invalidate_tags() functions. Or are you just referencing that issue as one that has removed those things to do with page caching?

damiankloip’s picture

Status: Postponed » Needs review
FileSize
1.75 KB
damiankloip’s picture

FileSize
2.79 KB

Removing the lines including cache.inc in the patch also helps.

The last submitted patch, 3: 2198339.patch, failed testing.

Berdir’s picture

Status: Needs review » Reviewed & tested by the community

Great.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Looks like the change notice at https://drupal.org/node/1272696 covers the functions removed here, sooo...

Committed and pushed to 8.x. Thanks!

webchick’s picture

Status: Fixed » Needs work

Sorry, nevermind. This broke HEAD because a new instances of cache() was added in the meantime. :\ Reverted.

longwave’s picture

Status: Needs work » Needs review
FileSize
3.79 KB
1016 bytes
longwave’s picture

FileSize
3.79 KB
1017 bytes

Oops.

The last submitted patch, 9: 2198339-remove-cache-inc-9.patch, failed testing.

tstoeckler’s picture

Status: Needs review » Reviewed & tested by the community

Looks good!

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed cb566fa and pushed to 8.x. Thanks!

Can we add the removal of this file to the relevant change notice.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.