Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Deprecated function: preg_replace(): The /e modifier is deprecated, use preg_replace_callback instead in MailMIME::toHeaders() (line 794 of D:\CMS\drupal-7.23\sites\all\modules\mailmime\mailmime.inc).
Same issue with the 7.x-2.18+0-dev version.
PHP 5.5.8 (cli) (built: Jan 8 2014 15:32:25)
Comment | File | Size | Author |
---|---|---|---|
#13 | interdiff_4_13.diff | 890 bytes | Mike Lewis |
#13 | mailmime-deprecated_function_preg_replace-2198587-13.patch | 1.02 KB | Mike Lewis |
#4 | deprecated_function_preg_replace-2198587-4.patch | 705 bytes | cs_shadow |
Comments
Comment #1
salvisPatch against the -dev version, anyone?
Comment #2
cs_shadow CreditAttribution: cs_shadow commentedThis patch uses preg_replace_callback() function instead of using \e modifier in preg_replace() function.
Comment #3
salvisThank you for the patch and sorry to let this sit for so long -- I was hoping for some who actually uses Mail MIME to review and test...
The patch looks good. However, according to https://drupal.org/requirements, PHP 5.3 is only recommended — we have to run under 5.2.5, which does not have anonymous functions. We must use create_function() instead.
Comment #4
cs_shadow CreditAttribution: cs_shadow commentedThis patch uses create_function() instead of anonymous function.
Comment #5
salvisThank you for the analysis and patch!
Comment #6
cs_shadow CreditAttribution: cs_shadow commented@salvis, doesn't this needs to be committed?
Comment #7
salvisI did:
https://drupal.org/commitlog/commit/20668/a09cfd68735c2b60d3d3a59c8fabd0...
Don't know why it's not reported here...
Comment #10
Anonymous (not verified) CreditAttribution: Anonymous commentedIs the commit not included? I downloaded today your module but this patch is missing.
Comment #11
my-family CreditAttribution: my-family commented+1, will it be commited? Thank you...
Comment #12
salvisI don't understand — when I look at https://cgit.drupalcode.org/mailmime/tree/mailmime.inc?h=7.x-2.x&id=a09cfd6, then I see the code from #4 on lines 782.
It's in the -dev version...
Comment #13
Mike Lewis CreditAttribution: Mike Lewis at Duo is now part of Mediacurrent! commentedI've rerolled #4 without the use of the deprecated create_function().