Support from Acquia helps fund testing for Drupal Acquia logo

Comments

swentel’s picture

Title: Rename Fieldinterface and FieldInstanceInterfce » Rename Fieldinterface and FieldInstanceInterface
swentel’s picture

Issue summary: View changes
swentel’s picture

Status: Postponed » Active

go go go

plopesc’s picture

yched’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Avoid commit conflicts

Looks good. Thanks !

webchick’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs change record

Neither this nor the parent issue has a change record?

webchick’s picture

yched’s picture

Status: Needs work » Reviewed & tested by the community
FileSize
59.48 KB

Reroll.

@webchick : the take in #2095303-53: Rename 'field_entity' to 'field_config' and 'field_instance' to 'field_instance_config' was to update existing change records - which would be friendlier once this issue is in, since the same set of records is likely to be affected ?

Temptatively putting back at RTBC.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 8: field_config_interfaces_rename-2200821-8.patch, failed testing.

yched’s picture

Status: Needs work » Reviewed & tested by the community
FileSize
59.31 KB

Gah, git snafu.

webchick’s picture

Priority: Normal » Major
Status: Reviewed & tested by the community » Active
Issue tags: -Needs change record +Missing change record

I guess that works, as long as someone actually does it. ;)

Committed and pushed to 8.x since this still applies, but leaving this open until the change notices are updated, since it doesn't look like they have been yet for #2095303: Rename 'field_entity' to 'field_config' and 'field_instance' to 'field_instance_config' either (or at least I'm still finding references to FieldInterface in sample code), and we don't want to lose track of this.

And unfortunately, committing this patch forces a re-roll of #2002134: Move TypedData metadata introspection from data objects to definition objects. :(

webchick’s picture

Issue tags: -Avoid commit conflicts

Don't need that tag anymore.

Berdir’s picture

Status: Active » Reviewed & tested by the community

Looks like this hasn't been pushed yet? Back to RTBC until that happened, patch still applies.

And don't worry about commit conflicts with #2002134: Move TypedData metadata introspection from data objects to definition objects, we're well aware that we're standing on our own feet with all those large issues, we have no problems with re-rolling them. As long as it's not one of those remove unsed variables issues that are conflicting, everything is fine :)

webchick’s picture

Status: Reviewed & tested by the community » Active

Gah! Sorry about that. Pushed. :)

xjm’s picture

Title: Rename Fieldinterface and FieldInstanceInterface » Change record updates: Rename Fieldinterface and FieldInstanceInterface
Issue tags: +Needs change record
plopesc’s picture

There is a list of updated change records in #2095303: Rename 'field_entity' to 'field_config' and 'field_instance' to 'field_instance_config'. Is that enough?

Regards

Berdir’s picture

Status: Active » Needs work

The change in https://drupal.org/node/2101747/revisions/view/2861833/6961317 is not correct, as that incorrectly renamed the old class name of a *different* FieldInterface that was renamed to FieldItemListInterface, needs to be reverted.

https://drupal.org/node/1805846 still references that same FieldInterface which is not related to this issue, but should be, while we're at it, renamed to FieldItemListInterface.

The other change records re FieldInterface I think all meant that other interface, which you correctly updated as far as I could see (we have way too many 8.x -> 8.x change records about field API changes but I think those just followed the process at the time, now it's obvious that it's too much... ).

https://drupal.org/node/2012896 is the main change notice about converting fields and field instances to entities, I'd suggest to update that to also mention* the interfaces renamed here and add a reference to both this issue and #2095303: Rename 'field_entity' to 'field_config' and 'field_instance' to 'field_instance_config'.

Then we should be done here.

*Edit: Do not mention the rename, just mention that the interfaces exist. Not sure if that was clear.

plopesc’s picture

Status: Needs work » Needs review

Hello,

Regards

jessebeach’s picture

Status: Needs review » Fixed
Issue tags: -Missing change record, -Needs change record

plopesc made all of the changes requested by Berdir in #17.

Berdir’s picture

Title: Change record updates: Rename Fieldinterface and FieldInstanceInterface » Rename Fieldinterface and FieldInstanceInterface

Yes, looks good, thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.