Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Split up from from #2095303: Rename 'field_entity' to 'field_config' and 'field_instance' to 'field_instance_config'
We can keep working in the same branch - field_config_entities_rename-2095303
Comment | File | Size | Author |
---|---|---|---|
#10 | field_config_interfaces_rename-2200821-10.patch | 59.31 KB | yched |
#8 | field_config_interfaces_rename-2200821-8.patch | 59.48 KB | yched |
#4 | field_config_interfaces_rename-2200821-4.patch | 59.26 KB | plopesc |
Comments
Comment #1
swentel CreditAttribution: swentel commentedComment #2
swentel CreditAttribution: swentel commentedComment #3
swentel CreditAttribution: swentel commentedgo go go
Comment #4
plopescFirst round once #2095303: Rename 'field_entity' to 'field_config' and 'field_instance' to 'field_instance_config' is in!
Comment #5
yched CreditAttribution: yched commentedLooks good. Thanks !
Comment #6
webchickNeither this nor the parent issue has a change record?
Comment #7
webchickAlso, this no longer applies, due to #2198343: Convert all usages of cache() and cache_invalidate_tags() procedural functions.
Comment #8
yched CreditAttribution: yched commentedReroll.
@webchick : the take in #2095303-53: Rename 'field_entity' to 'field_config' and 'field_instance' to 'field_instance_config' was to update existing change records - which would be friendlier once this issue is in, since the same set of records is likely to be affected ?
Temptatively putting back at RTBC.
Comment #10
yched CreditAttribution: yched commentedGah, git snafu.
Comment #11
webchickI guess that works, as long as someone actually does it. ;)
Committed and pushed to 8.x since this still applies, but leaving this open until the change notices are updated, since it doesn't look like they have been yet for #2095303: Rename 'field_entity' to 'field_config' and 'field_instance' to 'field_instance_config' either (or at least I'm still finding references to FieldInterface in sample code), and we don't want to lose track of this.
And unfortunately, committing this patch forces a re-roll of #2002134: Move TypedData metadata introspection from data objects to definition objects. :(
Comment #12
webchickDon't need that tag anymore.
Comment #13
BerdirLooks like this hasn't been pushed yet? Back to RTBC until that happened, patch still applies.
And don't worry about commit conflicts with #2002134: Move TypedData metadata introspection from data objects to definition objects, we're well aware that we're standing on our own feet with all those large issues, we have no problems with re-rolling them. As long as it's not one of those remove unsed variables issues that are conflicting, everything is fine :)
Comment #14
webchickGah! Sorry about that. Pushed. :)
Comment #15
xjmComment #16
plopescThere is a list of updated change records in #2095303: Rename 'field_entity' to 'field_config' and 'field_instance' to 'field_instance_config'. Is that enough?
Regards
Comment #17
BerdirThe change in https://drupal.org/node/2101747/revisions/view/2861833/6961317 is not correct, as that incorrectly renamed the old class name of a *different* FieldInterface that was renamed to FieldItemListInterface, needs to be reverted.
https://drupal.org/node/1805846 still references that same FieldInterface which is not related to this issue, but should be, while we're at it, renamed to FieldItemListInterface.
The other change records re FieldInterface I think all meant that other interface, which you correctly updated as far as I could see (we have way too many 8.x -> 8.x change records about field API changes but I think those just followed the process at the time, now it's obvious that it's too much... ).
https://drupal.org/node/2012896 is the main change notice about converting fields and field instances to entities, I'd suggest to update that to also mention* the interfaces renamed here and add a reference to both this issue and #2095303: Rename 'field_entity' to 'field_config' and 'field_instance' to 'field_instance_config'.
Then we should be done here.
*Edit: Do not mention the rename, just mention that the interfaces exist. Not sure if that was clear.
Comment #18
plopescHello,
Regards
Comment #19
jessebeach CreditAttribution: jessebeach commentedplopesc made all of the changes requested by Berdir in #17.
Comment #20
BerdirYes, looks good, thanks.