This issue has novice tasks. If you are an experienced core developer and have multiple commit mentions, please review novices' work on these tasks rather than doing them yourself. Feedback from experienced contributors is valued.

Problem/Motivation

We now refer to entity_info as entity_type see #2005716: Promote EntityType to a domain object. field_test_entity_type_translatable() is inconsistent.

Proposed resolution

Rename field_test_entity_info_translatable to field_test_entity_type_translatable

Remaining tasks

User interface changes

API changes

Contributor tasks needed
Task Novice task? Contributor instructions Complete?
Reroll the patch if it no longer applies. Instructions
Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standards Instructions
CommentFileSizeAuthor
#47 2201157-nr-bot.txt215 bytesneeds-review-queue-bot
#34 renamed-field_test_entity_info_translatable-to-field_test_entity_type_translatable-2201157-34.patch2.91 KBmattshoaf
#32 renamed-field_test_entity_info_translatable-to-field_test_entity_type_translatable-2201157-32.patch0 bytesmattshoaf
#27 renamed-field_test_entity_info_translatable-to-field_test_entity_type_translatable-2201157-27.patch2.91 KBakashkrishnan01
#16 renamed-field_test_entity_info_translatable-to-field_test_entity_type_translatable-2201157-16.patch2.96 KBpfugate
#6 renamed-field_test_entity_info_translatable-to-field_test_entity_type_translatable-2201157-6.patch3.02 KBJayeshSolanki
#3 renamed-field_test_entity_info_translatable-to-field_test_entity_type_translatable-2201157-3.patch1.2 KBJayeshSolanki
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Issue summary: View changes
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Assigned: Unassigned » plach

Renaming it would be a novice task, but I have no idea if we really need this and the corresponding alters anymore, see https://drupal.org/node/2143291.

Let's try to get some quick feedback from @plach.

JayeshSolanki’s picture

JayeshSolanki CreditAttribution: JayeshSolanki commented
FileSize
renamed-field_test_entity_info_translatable-to-field_test_entity_type_translatable-2201157-3.patch1.2 KB

I have renamed field_test_entity_info_translatable to field_test_entity_type_translatable.

JayeshSolanki’s picture

JayeshSolanki CreditAttribution: JayeshSolanki commented
Assigned: plach » JayeshSolanki
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: renamed-field_test_entity_info_translatable-to-field_test_entity_type_translatable-2201157-3.patch, failed testing.

JayeshSolanki’s picture

JayeshSolanki CreditAttribution: JayeshSolanki commented
FileSize
renamed-field_test_entity_info_translatable-to-field_test_entity_type_translatable-2201157-6.patch3.02 KB
JayeshSolanki’s picture

JayeshSolanki CreditAttribution: JayeshSolanki commented
Status: Needs work » Needs review
umar-ahmad’s picture

umar-ahmad CreditAttribution: umar-ahmad commented
Status: Needs review » Reviewed & tested by the community

All specified changes have been made

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Assigned: JayeshSolanki » plach
Status: Reviewed & tested by the community » Needs review

Thanks for the patch, I'd still love to get some feedback from @plach or maybe @yched on where we intend to go with this function...

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Assigned: plach » Unassigned

Thanks @berdir for pointing me to this: the function we are renaming here and the corresponding alter are no longer needed as they were useful only for the Field API legacy code. The 'translatable' entity property will be used to generate a multilingual entity schema, but it will not affect configurable fields, at least for now. If we actually get to altering CCK tables based on actual multilingual/revisionability support that alter could be needed again, so I guess we can go on and commit this.

Anyway, all things considered it would probably be better to refactor these tests and move them to the Entity group if they are just not a duplicate of EntityTranslationTest.

cilefen’s picture

cilefen CreditAttribution: cilefen commented

6: renamed-field_test_entity_info_translatable-to-field_test_entity_type_translatable-2201157-6.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 6: renamed-field_test_entity_info_translatable-to-field_test_entity_type_translatable-2201157-6.patch, failed testing.

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Issue summary: View changes

Updating for Austin sprints. See http://www.hook42.com/blog/prepping-drupalcon-austin-sprints-sprint-lead...

pfugate’s picture

pfugate CreditAttribution: pfugate commented
Assigned: Unassigned » pfugate

I am doing this for the sprint in Austin. I'm new!!

pfugate’s picture

pfugate CreditAttribution: pfugate commented
Issue tags: +needs-reroll

Patch no longer applies, I am rerolling it.

pfugate’s picture

pfugate CreditAttribution: pfugate commented
Status: Needs work » Needs review
Issue tags: -needs-reroll
FileSize
renamed-field_test_entity_info_translatable-to-field_test_entity_type_translatable-2201157-16.patch2.96 KB

The patch was 3 months old and no longer relevant. I created a new patch from scratch. Please review I have a 3:30 flight.

carsonevans’s picture

carsonevans CreditAttribution: carsonevans commented
Status: Needs review » Reviewed & tested by the community

I have successfully applied this patch locally. I don't really know how to test it otherwise. The functions changed are only referenced by core in these 3 files.

aaronschachter’s picture

aaronschachter CreditAttribution: aaronschachter commented

Same here, I've tested this patch locally and looks good to go.

Just a heads up @pfugate that the actual file name you've uploaded for the patch is over the character limit to allow others to use simplytest.me to test it.

Attempting to use simplytest.me results in: Theme or module shortname cannot be longer than 128 characters but is currently 131 characters long.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Reviewed & tested by the community » Postponed
Issue tags: -Novice

Thanks for the work on this, but see #10, renaming a function that ideally shouldn't exist at all seems a bit pointless. I'm not exactly sure what @plach meant without looking into it but it's probably not Novice and might be easier after #2143291: Clarify handling of field translatability, postponing on that for now and removing the tag.

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
Status: Postponed » Active
Related issues: +#2143291: Clarify handling of field translatability

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

waltria’s picture

waltria CreditAttribution: waltria commented
Issue summary: View changes

I will be working on this issue today at DrupalCon

thiagomp’s picture

thiagomp CreditAttribution: thiagomp commented
Issue summary: View changes

Making the post better readable

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

akashkrishnan01’s picture

akashkrishnan01 CreditAttribution: akashkrishnan01 commented

Anyone working on this?

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

akashkrishnan01’s picture

akashkrishnan01 CreditAttribution: akashkrishnan01 commented
FileSize
renamed-field_test_entity_info_translatable-to-field_test_entity_type_translatable-2201157-27.patch2.91 KB

This patch seems to be very old, so I have rerolled this patch.

akashkrishnan01’s picture

akashkrishnan01 CreditAttribution: akashkrishnan01 commented
Status: Active » Needs review
akashkrishnan01’s picture

akashkrishnan01 CreditAttribution: akashkrishnan01 commented

Any feedback for patch #27?

akashkrishnan01’s picture

akashkrishnan01 CreditAttribution: akashkrishnan01 commented
Assigned: pfugate » akashkrishnan01
mattshoaf’s picture

mattshoaf
he/him
Primary language English
Location Kansas City, MO, USA
CreditAttribution: mattshoaf commented

I started working on this as part of #DrupalConBaltimore2017.

I just tried to apply this, and it returned the following errors:

git apply --check renamed-field_test_entity_info_translatable-to-field_test_entity_type_translatable-2201157-27.patch
error: core/modules/field/src/Tests/TranslationTest.php: No such file or directory
error: core/modules/field/src/Tests/TranslationWebTest.php: No such file or directory
error: patch failed: core/modules/field/tests/modules/field_test/field_test.entity.inc:18
error: core/modules/field/tests/modules/field_test/field_test.entity.inc: patch does not apply

The TranslationTest.php and TranslationWebTest.php files have been moved to
core/modules/field/tests/src/Kernel/TranslationTest.php and core/modules/field/tests/src/Functional/TranslationTest.php respectively.

Enough lines have changed in field_test.entity.inc that they don't correspond to the patch anymore.

I should have a new patch ready to submit in a little bit.

mattshoaf’s picture

mattshoaf
he/him
Primary language English
Location Kansas City, MO, USA
CreditAttribution: mattshoaf commented
FileSize
renamed-field_test_entity_info_translatable-to-field_test_entity_type_translatable-2201157-32.patch0 bytes

Here's a reroll of the patch.

Status: Needs review » Needs work

The last submitted patch, 32: renamed-field_test_entity_info_translatable-to-field_test_entity_type_translatable-2201157-32.patch, failed testing.

mattshoaf’s picture

mattshoaf
he/him
Primary language English
Location Kansas City, MO, USA
CreditAttribution: mattshoaf commented
FileSize
renamed-field_test_entity_info_translatable-to-field_test_entity_type_translatable-2201157-34.patch2.91 KB

I messed up that patch, this one should work.

mattshoaf’s picture

mattshoaf
he/him
Primary language English
Location Kansas City, MO, USA
CreditAttribution: mattshoaf commented
Status: Needs work » Needs review

Changed to Needs Review so that the test bot will run, I manually tested on a vanilla Drupal install and all appears to be working properly.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

zymbian’s picture

zymbian CreditAttribution: zymbian as a volunteer commented

Do we need a reroll for #34 for new version 8.6.x ?

mattshoaf’s picture

mattshoaf
he/him
Primary language English
Location Kansas City, MO, USA
CreditAttribution: mattshoaf commented

I think so, I just queued it up to test with 8.6-dev using versions 5.6 and 7.1 of PHP.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

needs-review-queue-bot’s picture

needs-review-queue-bot CreditAttribution: needs-review-queue-bot as a volunteer commented
Status: Needs review » Needs work
FileSize
2201157-nr-bot.txt215 bytes

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.