Excel and deliminated exporting seems to have randomly stopped working on my installation. When exporting webform results, the progress bar moves through to 100% and indicates that the export succeeded but no file gets downloaded. When you click on the link to manually download the file, it indicates that the file no longer exists or may have already been downloaded.
Logs show the following:
Strict warning: Declaration of webform_exporter_excel_xlsx::eof() should be compatible with webform_exporter::eof(&$file_handle) in include_once() (line 5 of /home/cbforms/public_html/sites/all/modules/webform/includes/exporters/webform_exporter_excel_xlsx.inc).
The temp directory has a file created each time I try to download and they do not get cleared after the download. These temp files are not readable when opened in a text editor.
Can anyone point me in the right direction to restore Excel/Deliminated downloads for my forms.
Thanks.
Comment | File | Size | Author |
---|---|---|---|
#3 | webform_exporter_eof-2201489.patch | 874 bytes | quicksketch |
Comments
Comment #1
Liam MorlandI am getting similar error messages when exporting from some Webforms.
Delimited text export:
Microsoft Excel export:
Comment #2
mepadre CreditAttribution: mepadre commentedAfter much futzing, I went over some of the modules recently added since the site recently incorporated FileDepot with FileBuilder. It looks like the Background Batch module 7.x-1.16 is the conflicting module. I believe it was added as part of the Background Process module which FileBuilder requires but FileBuilder does not require the Background Batch portion of that module so I disabled it.
As soon as I disable / enable Background Batch, results file downloads start / stop respectively.
Hopefully, this helps someone else although I spent no time trying to determine exactly what was conflicting between the modules.
I also still have the following error after downloading results:
Strict warning: Declaration of webform_exporter_excel_xlsx::eof() should be compatible with webform_exporter::eof(&$file_handle) in include_once() (line 5 of /home/cbforms/public_html/sites/all/modules/webform/includes/exporters/webform_exporter_excel_xlsx.inc).
Thanks to everyone who works or contributes time to this module. It is easily one of the most necessary parts of a Drupal installation and has saved me countless hours of work.
Comment #3
quicksketchThis patch should fix that issue. We're not handling the eof() method consistently between exporters.
Liam, are the errors you're getting related? That may need to be its own issue if it looks like it's a problem with Webform that you're experiencing.
Comment #5
Liam MorlandMy thing may be different. New issue created: #2202499: Remove error suppression from fopen()
Comment #6
quicksketchNice, drupal.org's testbot finally is kicking in. Those test failures are not particular to this patch. I've made a new issue to fix the tests in #2202617: Tests failing when Token module not enabled.
I've committed the patch in #3 to solve the error in the original post. I'm not sure about solving the issue with "Background Batch" module. Any pointers as to how to resolve that issue would be appreciated.
Comment #7
mepadre CreditAttribution: mepadre commentedI found the following post as I was doing some searching:
#2059899: Blacklisting with background batch
Not sure if the hack/patch there might give some pointers on what could be changed in Webform to stop the issue?
Comment #8
quicksketchThanks @mepadre. It looks from that issue that they may be trying to actually fix an issue in Background Batch module that would fix Webform's exports from their side.
Comment #9
fenstrat#3 needs porting to 8.x-4.x.
Comment #10
fenstratCommitted and pushed d1b202f to 8.x-4.x.
Moving back to Active as per issue with "Background Batch" module.
Comment #12
DanChadwick CreditAttribution: DanChadwick commentedClosing as per #7, to be fixed in Background Batch. Setting to fixed re. the eof strict error.
Comment #14
karibou-mtl CreditAttribution: karibou-mtl commentedI use patch but I have same issue.
Any ideas ?