Multiple calls to ConfigFactory::get() inside t() is unnecessary [#2202143]

After doing a standard install, enabling locale and making 1 request to the frontpage the next request to the frontpage will make 240 calls to ConfigFactory::get(). With the attached patch this drops to 112 - meaning that there are 229 calls to LocaleTranslation::getStringTranslation(). There is also a massive reduction in calls for logged in users.

Comment	File	Size	Author
#6	interdiff.txt	533 bytes	benjy
#6	2202143_6.patch	1.92 KB	benjy
#6
#1	interdiff.txt	576 bytes	alexpott
#1	2202143.1.patch	1.92 KB	alexpott
#1
	d8.config-get-locale.patch	1.92 KB	alexpott

	xhprof - logged in.png	164 KB	alexpott
	xhprof-not-logged-in.png	161.1 KB	alexpott

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott commented 21 February 2014 at 13:20

File	Size
2202143.1.patch	1.92 KB

interdiff.txt	576 bytes

Fixed typo

Comment #2

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy commented 21 February 2014 at 13:42

Issue tags:

+language-ui

The change looks good. The setting is more meaning we SHOULD translate English (from a code point of view it means we *need* to look up the translation in case it is there). From a user point of view, it is indeed about CAN translate English. Anyway, this is minor nitpicking since the patch looks good :)

Comment #3

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 21 February 2014 at 16:14

+++ b/core/modules/locale/lib/Drupal/locale/LocaleTranslation.php
@@ -100,9 +106,23 @@ public function getStringTranslation($langcode, $string, $context) {
+    $this->translateEnglish = NULL;

very minor: unset($this->translateEnglish); would be much better as this is a bool property and we are trying to reset it.