drupal_parse_url
drupal_encode_path
_external_url_is_local
_drupal_http_use_proxy
valid_url

CommentFileSizeAuthor
#17 dep-url-2204157-17.patch4.31 KBAnonymous (not verified)
#14 interdiff-2204157-8-14.txt3.48 KBAnonymous (not verified)
#14 dep-url-2204157-14.patch13.99 KBAnonymous (not verified)
drupal8.dep-url.0.patch12.41 KBsun
#2 drupal8.dep-url.2.patch12.42 KBsun
#5 2204157-dep-url.5.patch12.9 KBAlumei
#7 dep-url-2204157-7.patch13 KBAnonymous (not verified)
#10 interdiff-2204157-7-8.txt6.52 KBAnonymous (not verified)
#10 dep-url-2204157-8.patch13.49 KBAnonymous (not verified)
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, drupal8.dep-url.0.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Needs work » Needs review
FileSize
drupal8.dep-url.2.patch12.42 KB

Sorry.

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
CreditAttribution: ianthomas_uk commented
Issue summary: View changes
ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Status: Needs review » Needs work
Issue tags: +Needs reroll
Alumei’s picture

Alumei CreditAttribution: Alumei commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
2204157-dep-url.5.patch12.9 KB

Re-Roll
=> Merged conflicts in commons.inc and FieldWebTest.php

Status: Needs review » Needs work

The last submitted patch, 5: 2204157-dep-url.5.patch, failed testing.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
FileSize
dep-url-2204157-7.patch13 KB

Another reroll. Fixed merge conflicts in locale.module, PublicStream.php and common.inc.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 7: dep-url-2204157-7.patch, failed testing.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Needs work » Needs review
FileSize
dep-url-2204157-8.patch13.49 KB
interdiff-2204157-7-8.txt6.52 KB

Seems like Url became UrlHelper to avoid confusion in #2184653. Let's try this again.

The last submitted patch, 10: dep-url-2204157-8.patch, failed testing.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Needs review » Needs work

In the previous patch, I forgot to change a Url to UrlHelper in form.inc. Nevertheless, I'm not sure what causes the other failures.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented 
+++ b/core/includes/common.inc
@@ -2625,7 +2517,7 @@ function _drupal_add_library($library_name, $every_page = NULL) {
-      \Drupal::moduleHandler()->alter('library', $library, $library_name);
+      drupal_alter('library', $library, $module, $name);

Unrelated?

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
FileSize
dep-url-2204157-14.patch13.99 KB
interdiff-2204157-8-14.txt3.48 KB

@penyaskito: It doesn't seem related, but I replaced it anyway since this seems to be a merge error.

I also fixed the error in form.inc, as well as an error in UrlTest.php

This will probably still not pass, but I'm curious to see the feedback testbot will give now.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Needs work » Needs review
ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented

this issue conflicts with #2221695: Remove uses of deprecated URL functions
i would suggest postpone this until the issue above is in (which removes usages) and then simply remove the functions here

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
FileSize
dep-url-2204157-17.patch4.31 KB

Rerolled once more after the issue that ParisLiakos mentioned was fixed.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Needs review » Reviewed & tested by the community
sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Assigned: sun » Unassigned
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

  • Commit 5548431 on 8.x by catch: 
    Issue #2204157 by pjonckiere, sun, Alumei: Remove deprecated URL helper...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.