When using the date_select element in a form definition without a #default_value, an undefined index warning is produced:

'Notice: Undefined index: #default_value in date_select_element_process() (line 462 of /sites/all/modules/contrib/date/date_api/date_api_elements.inc)

Sample code:

$form['subscribe']['date'] = array(
    '#type' => 'date_select',
    '#title' => t('Date'),
    '#date_format' => 'F-d-Y',
    '#date_year_range' => '0:+1',
    '#date_label_position' => 'within',
    '#validated' => TRUE,
);
CommentFileSizeAuthor
#6 date_api_elements-2204713-6.patch623 bytesjstoller
#5 interdiff-2204713-4-5.txt1.36 KBBR0kEN
#5 date_api-undefined-index-in-date_select_element_process-2204713-5.patch2.16 KBBR0kEN
#4 date_api-undefined-index-in-date_select_element_process-2204713-4.patch825 bytesBR0kEN
#2 date_api_elements-2204713-2.patch784 bytesgaurav.goyal
#1 date_api_elements-2204713-1.patch625 bytesebeyrent
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ebeyrent’s picture

ebeyrent CreditAttribution: ebeyrent commented
FileSize
date_api_elements-2204713-1.patch625 bytes

Here's a patch.

gaurav.goyal’s picture

gaurav.goyal CreditAttribution: gaurav.goyal commented
FileSize
date_api_elements-2204713-2.patch784 bytes

This bug was also there in the Date 7.x-2.6 Version, Above patch #1 solves the problem. But there was an error in apply the patch

date_api_elements-2204713-1.patch:10: trailing whitespace.
if (array_key_exists('#default_value', $element) && is_array($element['#default_value'])) {
warning: 1 line adds whitespace errors.

Just added a little to it, now it can be applied, attached is the patch.

BR0kEN’s picture

BR0kEN
Primary language Ukrainian
CreditAttribution: BR0kEN as a volunteer and at FFW for FFW commented
Title: Undefined index » Undefined index #default_value in date_select_element_process
Version: 7.x-2.7 » 7.x-2.x-dev
Status: Active » Needs review
BR0kEN’s picture

BR0kEN
Primary language Ukrainian
CreditAttribution: BR0kEN as a volunteer and at FFW for FFW commented
FileSize
date_api-undefined-index-in-date_select_element_process-2204713-4.patch825 bytes
BR0kEN’s picture

BR0kEN
Primary language Ukrainian
CreditAttribution: BR0kEN as a volunteer and at FFW for FFW commented
FileSize
date_api-undefined-index-in-date_select_element_process-2204713-5.patch2.16 KB
interdiff-2204713-4-5.txt1.36 KB

Oops, forgot some changes. Ignore previous patch.

jstoller’s picture

jstoller
he/him
CreditAttribution: jstoller as a volunteer and at California Science Center commented
FileSize
date_api_elements-2204713-6.patch623 bytes

The patch in #2 fixes the problem, but doesn't apply properly since the paths are off. The attached patch will apply from the module's root directory.

The patch in #5 seems to work as well, but it makes a bunch of apparently unrelated changes with no explanation, so I'm avoiding it for now.

jstoller’s picture

jstoller
he/him
CreditAttribution: jstoller as a volunteer and at California Science Center commented
Status: Needs review » Reviewed & tested by the community

I've been using this for two years now, so seems safe to commit.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.