Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.In the last version of webform 7.x-4.0-beta3 the function webform_get_submission has only two parameters and no more parameter "reset" to reset the drupal cache. In the documentation for this module in the web this parameter is always existing.
Will the parameter "reset" exist in the future? Which alternative could be used to be sure to get the submission right from database instead from cache?
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 2205757-backward-compatibility.patch | 772 bytes | stefan.r |
Comments
Comment #1
quicksketchBecause webform_get_submission() uses drupal_static(), you can reset the static cache by using
drupal_static_reset('webform_get_submission'). This function was introduced in D7 specifically to prevent the need for reset parameters all over the place.Comment #3
stefan.r CreditAttribution: stefan.r commentedI realize these pesky reset parameters are annoying, but we don't want to accidently break other custom modules using this function in a 3.x->4.x upgrade.
May be worth either putting back the param for backward compatibility or clearly spelling out the API change in the docs.
Comment #4
stefan.r CreditAttribution: stefan.r commentedComment #6
stefan.r CreditAttribution: stefan.r commentedNot sure why those tests failed? This patch shouldn't affect them...
Either way, if we don't want the patch and get rid of the $reset parameter, we should at least update the docs:
https://drupal.org/node/1609324
Comment #7
stefan.r CreditAttribution: stefan.r commentedComment #8
stefan.r CreditAttribution: stefan.r commented3: 2205757-backward-compatibility.patch queued for re-testing.
Comment #9
DanChadwick CreditAttribution: DanChadwick commentedThis won't be committed for the reason quicksketch said, but it would be wonderful if you would write a note in the 3 to 4 upgrade page: https://www.drupal.org/node/1609324