While the like widget on the widget settings page in Service Links has a locale field, the share widget does not. The widget defaults to en_US when viewed on a page.

It would be nice to have the locale field for the share widget as well.

CommentFileSizeAuthor
#4 fb_share_button_locale-2206875-3.patch2.34 KBmvonfrie
#1 fb_share_button_locale-2206875.patch2.29 KBdj1999
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dj1999’s picture

dj1999 CreditAttribution: dj1999 commented
Status: Active » Needs review
FileSize
fb_share_button_locale-2206875.patch2.29 KB

Hi,

created a patch, please review it.

Regards!
Joe

Talkless’s picture

Talkless CreditAttribution: Talkless commented

Could it be reviewed, please?

This is really a must-have.

mvonfrie’s picture

mvonfrie CreditAttribution: mvonfrie commented

The patch works, I just added a smal change to it. The locale field in the widget settings form must be required because if the user removes the locale the share buttons stops working. This is because the locale is part of the script url here and not a parameter as for the like widget.

mvonfrie’s picture

mvonfrie CreditAttribution: mvonfrie commented
FileSize
fb_share_button_locale-2206875-3.patch2.34 KB
hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
CreditAttribution: hanoii commented
Status: Needs review » Reviewed & tested by the community

seems to work just fine

Simon Georges’s picture

Simon Georges CreditAttribution: Simon Georges at Makina Corpus commented
Status: Reviewed & tested by the community » Fixed

I committed the patch from #2499217: Support for localized Facebook share button , same as this one. I apologize for not crediting you.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.