Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Follow-up to #2207341: "Re-run tests" form action broken
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | drupal8.simpletest-results-ui.9.patch | 6.85 KB | sun |
| #1 | whenfailsandpasses.png | 362.95 KB | YesCT |
| #1 | justfailing.png | 403.41 KB | YesCT |
| #1 | justpasses.png | 181.33 KB | YesCT |
| drupal8.simpletest-results-ui.0.patch | 6.86 KB | sun | |
Comments
Comment #1
YesCT CreditAttribution: YesCT commentedI read all the lines in the patch. Looks fine, nothing jumps out to concern me.
tested it with only passing tests
(entityaccess)
with only passing, primary button is return to list
and just failing
(patch from #1906810: Require type hints for automatic entity upcasting test: languageselect)
and both
when some fails, primary button is rerun tests.
very nice.
Comment #2
Wim LeersVery nice indeed :)
Comment #3
Dries CreditAttribution: Dries commented"Return to list" is still odd to me. It seems like that should be a link as it takes you to page instead of performing an action? Also, is "Back to overview" a better name?
Comment #4
Dries CreditAttribution: Dries commentedAnother thing that is slightly confusing in the screenshots: it says there are 6 fails but in the drop-down menu it says "Fail (1)". This seems to suggest there is 1 failure. I figure this could confuse people.
Comment #5
YesCT CreditAttribution: YesCT commentedI think it is worth making return to list an action, so that it can be clear that that is the usual thing when everything passes. It is the primary thing to do then.
Fail (1) ... is a preexisting problem and not the fault of this issue.
We can fix that in another issue. Maybe to make it be Fail (1 test class)
And the other .. 38 asserts pass, 6 asserts failed, 3 debug messages.
But I dont know if asserts is universally accurate.
Comment #6
YesCT CreditAttribution: YesCT commentedrelated issue created.
Comment #7
sunComment #9
sunDiff context conflict.
Comment #11
sun9: drupal8.simpletest-results-ui.9.patch queued for re-testing.
Comment #12
sunBack to RTBC.
For anyone who'd like to help getting rid of this: #2216701: Random test failure in ToolbarAdminMenuTest
Comment #14
sun9: drupal8.simpletest-results-ui.9.patch queued for re-testing.
Comment #15
YesCT CreditAttribution: YesCT commentedthat random fail is fixed so should be rtbc still.
Comment #25
quietone CreditAttribution: quietone as a volunteer commentedTriaging issues in simpletest.module to determine if they should be in the Simpletest Project or core.
This looks like it a simpletest module issue, changing the project.