Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
As features override might be best practice to make your own custom stuff to the existing features, it should probably be included by default in Panopoly?
Comment | File | Size | Author |
---|---|---|---|
#8 | panopoly_core-features-override-2208783-8.patch | 447 bytes | dsnopek |
#4 | panopoly_core-features-override-2208783.patch | 434 bytes | mrfelton |
Comments
Comment #1
dsnopekThis definitely makes sense to me. I don't think any Drupal 7 distribution is going to escape needed to either use Features Override or tell it's users to use Features Override.
In fact, I just recommended this to @barraponto here: #2208823: Set Pathauto patterns as defaultconfig, not strongarm
:-)
Comment #2
mrfelton CreditAttribution: mrfelton commentedWe used to use this a fair bit, but have recently discovered that it is a massive performance hog and just having in installed results in tens of thousands of hook invocations. By disabling this on one of our distributions we were able to reduce cache flush and features rebuild times by about 1/3. I love the idea of the features override module, but in practice I don't think it is an efficient way to implement features overrides. Certainly, not in its current state.
Comment #3
dsnopekHrm, that's really interesting about the performance issues! I use Features Override a lot. :-/ Is there an issue in its queue about this?
Comment #4
mrfelton CreditAttribution: mrfelton commentedUnfortunately, I didn't create an issue in the features_override issue queue at the time when I did the profiling and I don't have the data to prove it anymore. Even so, I do think there is value in including this module in the distribution for site builders as it is a common approach for overriding features for those that don't want to write code. I wouldn't want to see it enabled by default though, and I don't think we should actually be using it directly in any of our features. But since the distribution is 100% Features based, giving people an option for easily overriding them might be nice. So, with that in mind here is a patch to add it to the distro:
That said, do we have a policy on including modules that we don't actually use? We currently include modules like devel, uuid, and defaultcontent in the profile which are not strictly needed but nice to have's for developers.
Thoughts?
Comment #5
dsnopekI agree!
I don't think we have an official policy. I'd just say that we should always do this very carefully, because we still don't have a solution for removing modules from a .make file safely. But I think Features Override is going to be useful in the long-term in Drupal 7, so I'm not personally worried about including it. :-)
Comment #6
dsnopekCommitted!
Comment #8
dsnopekEep! There was a type-o in that patch. New version - will commit in a moment.
Comment #10
dsnopekCommited!