Follow-up from #2208597-8: Devel HEAD broken: Update calls to config(), drupal_map_assoc, Drupal\Core\Mail\PhpMail

Currently content generation uses outdated approach for comment fields.
Also form should use D8 element 'tableselect'

PS: Patch needs follow-up to properly inject all other services that used by plugin

CommentFileSizeAuthor
#2 devel-comment-2.patch10.57 KBandypost
#2 interdiff.txt1.53 KBandypost
#1 devel-comment-1.patch9.17 KBandypost
#1 interdiff.txt928 bytesandypost
devel-comment.patch9.17 KBandypost
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
FileSize
interdiff.txt928 bytes
devel-comment-1.patch9.17 KB

just a nitpicks

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
FileSize
interdiff.txt1.53 KB
devel-comment-2.patch10.57 KB

Finally generation work, also without comment module

The last submitted patch, devel-comment.patch, failed testing.

pcambra’s picture

pcambra
he/him
Primary language Spanish
Location Asturies
CreditAttribution: pcambra commented

2: devel-comment-2.patch queued for re-testing.

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented
Assigned: Unassigned » pcambra

@pcambra has been looking after generate.

pcambra’s picture

pcambra
he/him
Primary language Spanish
Location Asturies
CreditAttribution: pcambra commented
Status: Needs review » Needs work

Setting as needs work, it seems that we're displaying the comment settings as closed when they're open and on comment generation, a fatal is thrown when selecting a number of comments

( ! ) Fatal error: Call to undefined method Drupal\node\Entity\Node::entityType() in devel_generate.module on line 109

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

That call should be getEntityTypeId().

  • Commit bfbfbd7 on 8.x-1.x by pcambra: 
    Issue #2208979 by andypost, pcambra: Comment module fixes.
pcambra’s picture

pcambra
he/him
Primary language Spanish
Location Asturies
CreditAttribution: pcambra commented
Status: Needs work » Fixed

Committed with quite a few updates chasing D8 HEAD. Thanks a lot @andypost

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.