Any changes made to header in hook_webform_csv_header_alter() are not visible in actual CSV export file.

This blocks localization of export files: #2209419: Refactor component localization process and add missing translations.

CommentFileSizeAuthor
#1 webform-csv_header_alter_hook-2210433-1.patch1.05 KBmikran
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mikran’s picture

mikran CreditAttribution: mikran commented
Status: Active » Needs review
FileSize
webform-csv_header_alter_hook-2210433-1.patch1.05 KB

Attached patch moves alter hook few lines up so alterations can be made prior to merging component header to overall CSV header.

quicksketch’s picture

quicksketch
he/him
CreditAttribution: quicksketch commented

Doh, haha. You're quite right. It took me a couple minutes to find the bug even when I was looking right at it. This may need to be applied to the 3.x branch as well.

quicksketch’s picture

quicksketch
he/him
CreditAttribution: quicksketch commented
Status: Needs review » Fixed

Committed to all branches. Thanks!

  • Commit 9789b36 on 7.x-3.x by quicksketch: 
    Issue #2210433 by mikran: Hook_webform_csv_header_alter() does not...
  • Commit 5ce29f2 on 7.x-4.x by quicksketch:
    Issue #2210433 by mikran: Hook_webform_csv_header_alter() does not...

  • Commit 1d58e67 on 6.x-3.x by quicksketch: 
    Issue #2210433 by mikran: Hook_webform_csv_header_alter() does not...
quicksketch’s picture

quicksketch
he/him
CreditAttribution: quicksketch commented
Status: Needs review » Fixed
fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
CreditAttribution: fenstrat commented
Version: 7.x-4.x-dev » 8.x-4.x-dev
Assigned: Unassigned » fenstrat
Status: Fixed » Patch (to be ported)

Needs porting to 8.x-4.x.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
CreditAttribution: fenstrat commented
Version: 8.x-4.x-dev » 7.x-4.x-dev
Assigned: fenstrat » Unassigned
Status: Patch (to be ported) » Fixed

Committed and pushed 5ce29f2 to 8.x-4.x. Thanks!

  • Commit ffe26e7 on 8.x-4.x authored by mikran, committed by fenstrat: 
    Issue #2210433 by mikran: Hook_webform_csv_header_alter() does not...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.