Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I was seeing errors that my destination directory could not be created. There's a problem in MigrateFile::processFile(). file_prepare_directory() expects the $directory arg to be passed by reference, which you can't do when passing the return value of a function. The fix is to the separate drupal_dirname() call from the file_prepare_directory() call. Patch attached.
Comment | File | Size | Author |
---|---|---|---|
#2 | migrate.file-mkdir.patch | 856 bytes | dnmurray |
Comments
Comment #1
dnmurray CreditAttribution: dnmurray commentedMaybe I should test these things. New patch, that doesn't trash destination filename.
Comment #2
dnmurray CreditAttribution: dnmurray commentedOK, now I just want to delete this and start over... At any rate, I think I got the right patch file attached this time.
Comment #3
13rac1 CreditAttribution: 13rac1 commentedSetting to Needs Review to run tests.
Comment #4
13rac1 CreditAttribution: 13rac1 commentedImplementation looks sound. Patch doesn't apply.
Comment #7
mikeryanCommitted, thanks!
@dnmurray: For future reference, generate contrib module patches from the module's directory, not docroot.
Comment #8
mikeryanTagging as 2.6.
Comment #10
dnmurray CreditAttribution: dnmurray commented@mikeryan Thanks. I should have taken care of that. I need to stop by more often.