Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
I needed this for something at work, it was generic enough that I decided to roll it as a patch to views directly.
Comment | File | Size | Author |
---|---|---|---|
#10 | interdiff-2210755-10.txt | 1.06 KB | damiankloip |
#10 | 2210755-10.patch | 3.84 KB | damiankloip |
Comments
Comment #1
tim.plunkettComment #2
dawehnerD8 like.
Comment #3
tim.plunkettWoot!
Comment #4
jibranWe should add test for this as well.
Comment #5
damiankloip CreditAttribution: damiankloip commentedHere is a quick test.
Comment #6
dawehnerIf we test such low level we could use actual unit tests right from the beginning. I don't see much of integration going on here. What do you think?
Comment #7
damiankloip CreditAttribution: damiankloip commentedYeah, sure. I just used an existing test and made it what I wanted :)
This could be a real unit test pretty easily. Leave it with me.
Comment #8
damiankloip CreditAttribution: damiankloip commentedHere we go.
Comment #9
dawehnershould we also add defineOptions here?
you should really autocomplete more
let's skip that empty line
Comment #10
damiankloip CreditAttribution: damiankloip commentedSorry, forgot about this issue. I guess everyone else did too. Either that or no one cares :)
Comment #12
damiankloip CreditAttribution: damiankloip commented10: 2210755-10.patch queued for re-testing.
Not sure I believe all of those fails.
Comment #13
damiankloip CreditAttribution: damiankloip commentedComment #14
dawehnerWe do care, but we just care about more than one issue
Comment #16
tim.plunkett10: 2210755-10.patch queued for re-testing.
Comment #17
tim.plunkettComment #19
tim.plunkettImageStylesPathAndUrlTest--
Comment #20
alexpott10: 2210755-10.patch queued for re-testing.
Comment #21
alexpottI'm confused - wouldn't this mean that the messages would be moved from one location to another if the theme has an area for displaying messages? Like what is the use-case?
Comment #22
tim.plunkettThe use case I had was a view loaded in a modal, the messages were displaying on the page underneath, and I needed them right alongside the view.
On a whim I submitted it as a D7 views patch (which was committed), and this issue just exists to keep feature parity.
Comment #23
alexpottCommitted 04dd275 and pushed to 8.x. Thanks!