Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
As discussed here #2213757: Should transliteration be a part of Panopoly SEO transliteration should probably be part of panopoly-core as it adds some sanity to e.g. file names.
Comment | File | Size | Author |
---|---|---|---|
#5 | panopoly_core-transliteration-2213769-5.patch | 1.23 KB | caschbre |
Comments
Comment #1
caschbre CreditAttribution: caschbre commentedGreat idea! It's a module I include on every site I build.
Comment #2
caschbre CreditAttribution: caschbre commentedAfter installing it locally I didn't see any configuration / exports that needed to be changed. So adding it to panopoly_core .info/.make files.
Comment #3
caschbre CreditAttribution: caschbre commentedComment #4
mrfelton CreditAttribution: mrfelton commentedIf we are considering this a standard module now, I think this should be enabled automatically for existing sites in the upgrade process.
Comment #5
caschbre CreditAttribution: caschbre commentedYep!
Comment #6
mglamanUpgraded just fine! Rebuilt a-okay, too.
Comment #8
mrfelton CreditAttribution: mrfelton commentedCommitted! Waiting for build result
https://travis-ci.org/panopoly/panopoly/builds/30383279
Comment #9
miromarchi CreditAttribution: miromarchi commentedHi, thanks for the job here.
As a panopoly base distribution user, I wish to share my experience after upgrading to panopoly1.8 with transliteration module included. This is a sort of log.
drush make panopoly1.8.make
. Makefile content:admin/reports/status
and I see I have pending database updates and I need to run the update script (update.php
).Pending updates are:
I got these log messges:
Then I got the message:
Transliteration has been installed. <em>Fix existing file names</em>.
Which links toadmin/config/media/file-system/transliteration
.The page also shows the warning:
I have this success message:
and also 135 notices:
Line 120 is
if ($file->metadata['width'] != $file->metadata['width'] || $file->metadata['height'] != $file->metadata['height']) {
admin/content/file
to check devel on a random transliterated file.On
devel
I check propertymetadata
and I see:which is the same as before transliteration (I checked on production site).
But on
devel/render
I see this file array:While original file showed this array:
#width
and#height
attributes.There is only a minor issue with images inserted with wysiwyg interface. If I click on the image, then I hit on "add media" button which prompts the modal for embedding the image, and I want to change size say from "original size" to "quarter size", nothing happens. While before update 7100 (I check it in production site) this actions resulted in a img resize. If I delete the embed img and re-add it, everything is back to work.
admin/config/media/file-system/transliteration
?Undefined property: stdClass::$metadata in file_entity_file_update() (line 120 of /sites/all/modules/contrib/file_entity/file_entity.file.inc)
just saying transliteration process loose "width" and "height" attributes of renamed files?Thank you very much