Problem/Motivation

When you enter a description for an exposed views filter, the description won't be displayed.

Proposed resolution

The description should display.

Remaining tasks

User interface changes

API changes

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug
Unfrozen changes Unfrozen because it only changes code necessary to fix a bug
Prioritized changes The main goal of this issue is usability.
CommentFileSizeAuthor
#8 2215473-8.patch2.03 KBLendude
#7 2215473-7-SHOULDFAIL.patch1.53 KBLendude
#4 core-rendering-exposed-filter-description-2215473-4.patch508 bytesAnonymous (not verified)
views_exposed_form_filter_description.PNG15.98 KBtte
views_exposed_form_filter_description.patch524 bytestte
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

webflo’s picture

webflo CreditAttribution: webflo commented
Issue tags: +Regression
marcingy’s picture

marcingy CreditAttribution: marcingy commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, views_exposed_form_filter_description.patch, failed testing.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
FileSize
core-rendering-exposed-filter-description-2215473-4.patch508 bytes

The description of the exposed filters indeed seems lost in translation. I wasn't able to apply the patch command line, so I applied it manually. The patch seems to properly fix the issue.
I attached a new patch. The difference seems to be that it doesn't include a "src" directory.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Needs work » Needs review
jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom commented
Status: Needs review » Needs work
Issue tags: +Needs tests, +VDC

Fix looks solid. Would it be possible to add a quick test to prevent the regression in the future? This could probably quickly be added to the Drupal\views\Tests\Plugin\ExposedFormTest.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude commented
Status: Needs work » Needs review
Issue tags: -Needs tests
FileSize
2215473-7-SHOULDFAIL.patch1.53 KB

Failing test for this.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude commented
FileSize
2215473-8.patch2.03 KB

Test plus the fix as given in #4

The last submitted patch, 7: 2215473-7-SHOULDFAIL.patch, failed testing.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

I've updated the issue summary and added a beta phase evaluation. This looks good to go. Thanks for adding the test!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 315c2a8 and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.

  • alexpott committed 315c2a8 on 8.0.x 
    Issue #2215473 by Lendude, speely, pjonckiere: Filter description not...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.