plugins/access/theme.inc checks d6 global $custom_theme, d7 is menu_get_custom_theme() [#2216461]

Found some depracated custom code referencing custom_theme, so did a grep for the global and only place referencing it was ctools. Looks like the new way is menu_get_custom_theme()

d6 checking custom_theme: https://api.drupal.org/api/drupal/includes%21theme.inc/function/init_the...
d7 checking menu_get_custom_theme: https://api.drupal.org/api/drupal/includes%21theme.inc/function/drupal_t...

Comment	File	Size	Author
#5	ctools-2216461-5.patch	571 bytes	silvi.addweb
#1	2216461-ctools-custom_theme-1.patch	573 bytes	hefox

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

hefox CreditAttribution: hefox commented 12 March 2014 at 17:49

File	Size
2216461-ctools-custom_theme-1.patch	573 bytes

Comment #2

hefox CreditAttribution: hefox commented 12 March 2014 at 17:51

Issue summary:

View changes

Comment #3

2 January 2015 at 14:27

DamienMcKenna queued 1: 2216461-ctools-custom_theme-1.patch for re-testing.

Comment #4

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented 3 January 2019 at 01:53

Status:	Needs review	» Needs work
Issue tags:		+Needs reroll

1 file was hidden/shown/deleted

File	Size
2216461-ctools-custom_theme-1.patch	573 bytes

The 5 year old patch to theme.inc does not apply to the latest ctools 7.x-1.x-dev so needs a reroll.

Checking patch plugins/access/theme.inc...
error: while searching for:
  if (!empty($GLOBALS['theme'])) {
    $theme = $GLOBALS['theme'];
  }
  else if (!empty($GLOBALS['custom_theme'])) {
    $theme = $GLOBALS['custom_theme'];
  }
  else if (!empty($GLOBALS['user']->theme)) {
    $theme = $GLOBALS['user']->theme;

error: patch failed: plugins/access/theme.inc:44
error: plugins/access/theme.inc: patch does not apply

Comment #5

silvi.addweb CreditAttribution: silvi.addweb at AddWeb Solution Pvt. Ltd. commented 29 January 2019 at 17:39

Status:

Needs work

» Needs review

File	Size
ctools-2216461-5.patch	571 bytes

@Chris Matthews, Please find my attached patch that rerolls as per your mentioned requirement(version 7.x-1.x-dev). Hope this helps you. Feel free & kindly provide your feedback on the same.

Thanks!..