Problem/Motivation

There are a number of places in core...

... which put links in status, warning and error messages.

It would be helpful to have links in status, warning and error messages, since they typically have different background colors from the main theme, and links are often different than standard link colors.

Proposed resolution

Make the styleguide module output at least one link in the status, warning and error messages.

Remaining tasks

  1. Write patch
  2. Review & RTBC
  3. Commit
  4. Release a new version of Styleguide that includes this functionality.

User interface changes

A link is added to the status, warning and error messages.

API changes

None.

Original report by @jessehs

It would be helpful to have links in status, warning and error messages, since they typically have different background colors from the main theme, and links are often different than standard link colors.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jessehs’s picture

Status: Active » Needs review
FileSize
1.87 KB

Patch adds an optional $link argument to the styleguide_sentence() function that places a link at the beginning of the sentence.

nevergone’s picture

#1: PHP Notice message:
Notice: Undefined offset: 2 in styleguide_sentence() function (styleguide/styleguide.module line 429).

Corrected patch with theme_link().

mparker17’s picture

Status: Needs review » Reviewed & tested by the community

Code looks good and functions properly. As far as I'm concerned, this is RTBC!

mparker17’s picture

Issue summary: View changes

Updated issue summary, now with more motivation :)

  • jessehs authored e6c947b on 7.x-1.x
    Issue #2217329 by jessehs, nevergone, mparker17: Add links in status/...
dead_arm’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.