404 not found [#2217827]

using this modul I got 404 error on calls to mysite.com/favicon.ico

I found that the used theme_get_setting('favicon_path') returns public://favicon.ico which results in an empty realpath($favicon).

In _favicon_get_favicon_file() I have changed

  $favicon = theme_get_setting('favicon_path');

  $favicon = theme_get_setting('favicon_path');
  $files_dir = variable_get('file_public_path', conf_path() . '/files');
  $favicon = str_replace('public:/',$files_dir,$favicon);

in order to get the favicon correctly.

Comment	File	Size	Author
#7	favicon-404-not-found-fix-2217827-7-D7.patch	1.03 KB	oushen
#7
#5	favicon-404-not-found-fix-2217827-5-D7.patch	1.03 KB	oushen
#5
#2	realrealpath.txt	382 bytes	kingandy

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

johnennew CreditAttribution: johnennew commented 28 April 2014 at 17:57

Wording on the Drupal core settings page for the shortcut icon is terrible.

I think it means you to enter a file path which is relative to the site root, not the public files directory.

Comment #2

kingandy CreditAttribution: kingandy commented 5 August 2014 at 16:08

File	Size
realrealpath.txt	382 bytes

Maybe this is one of the rare cases when drupal_realpath() is appropriate?

... you know that the stream wrapper in the URI uses the local file system, and you need to pass an absolute path to a function that is incompatible with stream URIs.

I've tested on my local system (which was likewise using a 'public://' URI), and it seems to work fine. It also works with the default 'misc/favicon.ico' path, so I guess it would work with theme-default paths, but I haven't tested that.

Find attached a patch, though it's really a very simple change...

Comment #3

kingandy CreditAttribution: kingandy commented 5 August 2014 at 16:08

Status:

Active

» Needs review

Comment #4

cmseasy CreditAttribution: cmseasy commented 9 August 2014 at 11:56

#2 worked for me in a multisite drupal environment. Thanks!

Comment #5

oushen CreditAttribution: oushen commented 24 October 2014 at 09:53

File	Size
favicon-404-not-found-fix-2217827-5-D7.patch	1.03 KB

Patch for fix 404 error

Comment #6

24 October 2014 at 09:55

Status:

Needs review

» Needs work

The last submitted patch, 5: favicon-404-not-found-fix-2217827-5-D7.patch, failed testing.

Comment #7

oushen CreditAttribution: oushen commented 24 October 2014 at 10:35

File	Size
favicon-404-not-found-fix-2217827-7-D7.patch	1.03 KB

Fixed patch file after test failed

Comment #8

oushen CreditAttribution: oushen commented 24 October 2014 at 10:35

Status:

Needs work

» Needs review

Comment #9

24 October 2014 at 10:37

Status:

Needs review

» Needs work

The last submitted patch, 7: favicon-404-not-found-fix-2217827-7-D7.patch, failed testing.

Comment #10

oushen CreditAttribution: oushen commented 24 October 2014 at 10:49

Status:

Needs work

» Needs review

Comment #11

Dave Reid

he/him

English

Nebraska USA

CreditAttribution: Dave Reid commented 11 December 2014 at 18:50

Status:

Needs review

» Fixed

This should be resolved with the most recent release, 7.x-2.0. It is safe for everyone to upgrade to since there's no data that actually needs upgrading.