Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Add XING as authentication provider.
Comment | File | Size | Author |
---|---|---|---|
#1 | hybridauth-xing-2222173-1.patch | 1.1 KB | klausi |
Comments
Comment #1
klausiPatch attached.
Comment #2
duozerskKlaus,
Thank you for a patch.
I have a question here - isn't XING added to the list of providers when you just copy the XING.php provider implementation to the needed directory? (it should work, just not apply the t() function on the provider name) It seems to me that we should limit the hardcoded list of providers and use the providers implementation discovery mechanism for all the others.
Thoughts?
Thanks
AndyB
Comment #3
klausiRight, I added that line before I realized that I need to copy around stuff in the Hybridauth library. Which is pretty bad by the way, since a library update can easily remove that copied file and can break you site.
I agree that we should not have that hard-coded list. Maybe a help text would be useful pointing users to a documentation page where it says that they need to copy around provider files? Unfortunately I could not find such a page on http://hybridauth.sourceforge.net/userguide.html
Then we also need some XING icons to make this complete, where do you get the icons usually from?
Comment #4
duozerskYep, you need to copy the files in the library, and we could think of the way to determine if it got broken after the update - should be easy to do as we already have the files discovery mechanism.
There is a description on how to copy provider implementations in the module README file - we can definitely add something like this as help text.
For the icons - I usually search the web... using favicon of the official site as the 16px icon and then searching for icon packs to find other sizes. The icon packs included with the module are not complete, so usually you would need to create your own icon_pack ctools plugin (either in the module or a theme) with needed icons.
There is now support for the Zocial project - but it also doesn't have all the icons.
Thanks
AndyB
Comment #5
duozerskKlaus,
Just wanted to keep you updated that I have introduced the new ctools plugin type - provider - see http://drupalcode.org/project/hybridauth.git/commit/dfee54c
It should allow us to have provider specific settings (including icons and css for them - for those providers which icons didn't make it into the supplied icon packs) separated into plugin. See the DrupalOAuth2 provider plugin for example.
Thanks
AndyB
Comment #6
TimG1 CreditAttribution: TimG1 commentedHello everyone,
Man, what a great module. Works so nice! Thank you for your work on this.
I'm building a site now and I have it working perfectly with Twitter and LinkedIn. I would like to get it working with Xing too. I am happy to test and help where I can. I'm not savvy enough to help on the development, but am more than happy to test.
Thanks again for the module!
-Tim
Comment #7
duozerskTim,
It should work out of the box (as XING is now included in the additional providers of the HybridAuth library) - you just need to copy the XING.php provider implementation file to the "hybridauth/Hybrid/Providers" directory in your site libraries folder. See the module README.txt file - it explains how to do it.
Then you just need the icon pack with the icon for this provider - only the Zocial icon pack from the default ones has it (see the README.txt in hybridauth/plugins/icon_pack/zocial directory).
Hope it helps.
Thanks
AndyB
Comment #8
TimG1 CreditAttribution: TimG1 commentedThanks Andy! That worked great. Thanks for pointing me in the right direction.
All the best,
-Tim