Currently the code has:

  // Allow other modules to alter the coder definitions.
 drupal_alter('facetapi_pretty_paths_facetapi_pretty_paths_coders', $coders); 

I think this is a mistake, and I feel it should be:

  // Allow other modules to alter the coder definitions.
  drupal_alter('facetapi_pretty_paths_coders', $coders);

So custom coders could be added with hook_facetapi_pretty_paths_coders_alter() instead of hook_facetapi_pretty_paths_facetapi_pretty_paths_coders_alter()

Patch will follow

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rv0’s picture

Issue summary: View changes
Status: Active » Needs review
FileSize
491 bytes
dasjo’s picture

sounds good, given that this is an API change i think we should keep the old hook in place and mark it as deprecated.
what do you think?

dasjo’s picture

and of course we should document our hooks, but that could be a separate issue

dasjo’s picture

FileSize
555 bytes

  • Commit f7d207a on 7.x-1.x authored by rv0, committed by dasjo:
    Issue #2222817 by dasjo, rv0: Rename alter hook for external coders.
    
dasjo’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.