Problem/Motivation

Configurable languages are configuration entities but we still have language CRUD hooks - this is unnecessary.

Proposed resolution

  • Remove hook_language_delete, hook_language_insert, hook_language_update, and hook_language_presave
  • Use hook_language_entity_delete, hook_language_entity_insert, hook_language_entity_update, and hook_language_entity_presave instead

Remaining tasks

Review patch

User interface changes

None

API changes

Remove hook_language_delete, hook_language_insert, hook_language_update, and hook_language_presave

CommentFileSizeAuthor
#2 2223249.2.patch9.9 KBalexpott
#1 2223249.1.patch0 bytesalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Active » Needs review
FileSize
2223249.1.patch0 bytes

Patch. Yay for every entity working the same way.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
FileSize
2223249.2.patch9.9 KB

Yay again :)

The last submitted patch, 1: 2223249.1.patch, failed testing.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Issue tags: +language-base, +sprint

Makes lots of sense :) Will review later.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

Related: #2166923: Move language entity (CR)UD API to a dedicated service

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs review » Reviewed & tested by the community

Looks good. All changes look logical, nice that the superfluous hooks are removed. Better for all :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs change record

Well this looks lovely! Needs a change notice still, though.

attila.fekete’s picture

attila.fekete CreditAttribution: attila.fekete commented

Prepared a change record for this issue: https://drupal.org/node/2225341

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

Woah, that looks great!

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs work » Reviewed & tested by the community
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented

Committed/pushed to 8.x, thanks!

  • Commit e1dd5a1 on 8.x by catch: 
    Issue #2223249 by alexpott: Remove hook_language_insert/update/delete/...
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Issue tags: -sprint, -Needs change record

Yay, this is a simple and great improvement :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.