Mark Title required only if Element and title settings is Required [#2224503]

If a Link Filed is not marked as required but title is marked as required, the Field rendered marks Title as Required only in Edit mode if URL data exists. Validation takes care that if URL is entered than the title is marked as required if its settings is marked as required.
But in this case, in Add mode the Title filed is not marked as required, but in Edit mode the title is marked required, which is confusing.

Comment	File	Size	Author
#10	interdiff-2224503-6-10.txt	1.33 KB	prudloff
#10	link-2224503-10.patch	806 bytes	prudloff
#10	7.x-1.x: PHP 8.0 & MySQL 5.7, D7 77 pass
#6	2224503-6-Link-Title-required-element-required.patch	828 bytes	Chris Burge
#6	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 21 pass, 23 fail
#2	2224503-2-Link-Title-required-element-required.patch	1.1 KB	rahulbile
#2	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 Patch Failed to Apply
#1	2224503-1-Link-Title-required-element-required.patch	1.11 KB	rahulbile
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

rahulbile CreditAttribution: rahulbile commented 24 March 2014 at 11:10

Status:

Needs work

» Needs review

File	Size
2224503-1-Link-Title-required-element-required.patch	1.11 KB

Currently the code tries to see if the URl is not empty it marks the title as required. It does not need to check the data of URL as in edit mode someone might want to delete the data for title and Link but Required mark confuses user. Also Other validation modules which does on page validation (Eg clientside validation) do not allow to save the form until data is entered for it. Attached is initial path which tries to solve the problem.

Comment #2

rahulbile CreditAttribution: rahulbile commented 24 March 2014 at 11:24

File	Size
2224503-2-Link-Title-required-element-required.patch	1.1 KB
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 Patch Failed to Apply

More clean patch.

Comment #3

rahulbile CreditAttribution: rahulbile commented 24 March 2014 at 11:32

Assigned:

rahulbile

» Unassigned

Comment #4

Chris Burge CreditAttribution: Chris Burge commented 23 February 2017 at 16:46

Priority:	Minor	» Normal
Status:	Needs review	» Reviewed & tested by the community

1 file was hidden/shown/deleted

File	Size
2224503-1-Link-Title-required-element-required.patch	1.11 KB

I can confirm this bug still exists in the current recommended release of Link. This patch resolves the issue. I changed the priority to Normal because the bug does adversely affect functionality.