The function field_group_info_groups() when called with $reset set to TRUE clears ALL CTools caches, and not just the caches relevant to the field_group module. This is an issue on sites I maintain, as the field_group_info_groups() function is called when rebuilding certain views, which results in parts of the views being lost.

The attached patch fixes this issue.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

SocialNicheGuru’s picture

how can you test this?

sdrycroft’s picture

Clearing a sites cache should be sufficient to test this. If you have any hook_views_default_views() functions, include a call to field_group_info_groups() in one of them, and watch how this function clears the views cache.

Besides, simply reading the code should be sufficient to see what has been changed, and that the code before was incorrect.

nils.destoop’s picture

Status: Needs review » Fixed

Thx for noticing. The patch has been committed to dev.

  • Commit 9cc0e64 on 7.x-1.x authored by sdrycroft, committed by zuuperman:
    Issue #2224547 by sdrycroft: Fixed field_group_info_groups() clears all...

  • Commit 9cc0e64 on 7.x-1.x, 8.x-1.x authored by sdrycroft, committed by zuuperman:
    Issue #2224547 by sdrycroft: Fixed field_group_info_groups() clears all...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Status: Closed (fixed) » Needs work
nils.destoop’s picture

Status: Needs work » Closed (fixed)