I noticed that I lost email whenever my first smtp server is down.
The second (backup) smtp server is never contacted nor taken into consideration.

Digging in the problem I found that the bundled phpmailer (modified from 5.1 version) in SmtpConnect() loops through the servers but exits the loops (raising an exception) as soon as it fails the first server.

So it simply ignores multiple servers.

CommentFileSizeAuthor
#15 smtp-n2226483-15.patch1.37 KBDamienMcKenna
#14 Screen shot 2016-01-30 at 10.49.08 PM.png35.89 KBAnonymous (not verified)
#7 smtp-n2226483-7.patch1.31 KBDamienMcKenna
#4 smtp-phpmailer-backup-host-2226483-4.patch1.3 KBbago
#1 smtp-phpmailer-backup-host-2226483.patch1.52 KBbago
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bago’s picture

bago CreditAttribution: bago commented
FileSize
smtp-phpmailer-backup-host-2226483.patch1.52 KB

A firtst attempt at fixing the issue and start using the backup server when the first server is not available.

bago’s picture

bago CreditAttribution: bago commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 1: smtp-phpmailer-backup-host-2226483.patch, failed testing.

bago’s picture

bago CreditAttribution: bago commented
FileSize
smtp-phpmailer-backup-host-2226483-4.patch1.3 KB

Another attempt formatting the patch

bago’s picture

bago CreditAttribution: bago commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: smtp-phpmailer-backup-host-2226483-4.patch, failed testing.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Version: 7.x-1.0 » 7.x-1.x-dev
Status: Needs work » Needs review
FileSize
smtp-n2226483-7.patch1.31 KB

Rerolled.

Status: Needs review » Needs work

The last submitted patch, 7: smtp-n2226483-7.patch, failed testing.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review

The tests failed because of a bug in DrupalCI: #2645590: Ensure that simpletest job doesn't "fail" testing if no tests are present

Status: Needs review » Needs work

The last submitted patch, 7: smtp-n2226483-7.patch, failed testing.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review

The tests pass, so marking this "needs review".

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous as a volunteer and commented

Retesting.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous as a volunteer and commented

Looks like it passed a couple times now. I put in que once more for good measure.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous as a volunteer and commented
FileSize
Screen shot 2016-01-30 at 10.49.08 PM.png35.89 KB

Worked perfect for me. Terminal image included.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
FileSize
smtp-n2226483-15.patch1.37 KB

I've tidied up the code a little to match the Drupal coding standards.

wundo’s picture

wundo CreditAttribution: wundo at Chuva Inc. for Chuva Inc. commented

  • wundo committed 7026c6e on 7.x-1.x authored by DamienMcKenna 
    Issue #2226483 by bago, DamienMcKenna, alex_drupal_dev, wundo: Backup...
wundo’s picture

wundo CreditAttribution: wundo at Chuva Inc. for Chuva Inc. commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.