Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
In the user.autocomplete service is injected the database service, but it isn't used there.
Comment | File | Size | Author |
---|---|---|---|
#9 | interdiff.txt | 3.6 KB | skipyT |
#9 | 2227391-autocomplete-without-db-service-7.patch | 2.73 KB | skipyT |
#6 | interdiff.txt | 566 bytes | skipyT |
#6 | 2227391-autocomplete-without-db-service-5.patch | 2.33 KB | skipyT |
#1 | 2227391-autocomplete-without-db-service-1.patch | 2.02 KB | skipyT |
Comments
Comment #1
skipyT CreditAttribution: skipyT commentedI removed the parameter from the services file and I updated the constructor also.
Comment #2
skipyT CreditAttribution: skipyT commentedComment #3
dawehnerNice! This is an easy one!
Comment #4
claudiu.cristeaThe property has been left inside. Remove this:
Comment #6
skipyT CreditAttribution: skipyT commentedThanks Claudiu!
Deleted the unused class property.
Comment #7
claudiu.cristeaRTBC if turns green.
Comment #8
alexpottThis looks great.
If we're fixing the constructor let's also change EntityManager to EntityManagerInterface.
Comment #9
skipyT CreditAttribution: skipyT commentedmodified the queryfactory to be an interface and rerolled the patch.
Comment #11
skipyT CreditAttribution: skipyT commentedthis seems it was fixed in #2306077. Closing this.