Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I tried clicking a proposed username to add an @mention in between two existing words (that is, while inserting text into existing text, not while typing at the end of a paragraph as normally).
This resulted in anything from the @username until the end of the current paragraph to be replaced with the linked username that I clicked. It leads to loss of text, but fortunately this can be undone with the Ctrl + Z undo feature of CKEditor.
(Issue observed with CKEditor 4.3.2 in Firefox 28.0 on Ubuntu 13.10.)
Comment | File | Size | Author |
---|---|---|---|
#5 | ggw_ckeditor_mentions-empty_textnode_content_after_tag.patch | 1.12 KB | 7gipsy |
Comments
Comment #1
tanius CreditAttribution: tanius commentedComment #2
askibinski CreditAttribution: askibinski commentedYes there are a lot of weird edge-case scenario's...
Could you perhaps tell me if the same thing happens in other browsers, especially Chrome and IE?
Comment #3
tanius CreditAttribution: tanius commentedThank you for the fast answer! I did some tests with all browsers that I had around: the above issue happened in all of them, namely:
In all cases, this used CKEditor 4.3.2.
Another interesting twist: If the current paragraph, somewhere after the position where one is typing to insert a mention, already contains a mention, this existing mention is the stop position up to which text is replaced. It's not alway up to the end of the paragraph – I have updated the issue title accordingly.
Comment #4
askibinski CreditAttribution: askibinski commentedYep, you are right.
Unfortunately, I don't think I will be able to dive into this anytime soon. Patches are welcome though ;)
Comment #5
7gipsy CreditAttribution: 7gipsy commentedHi guys,
Thanks for your work on this project.
Let me purpose you a patch for this issue.
Comment #7
askibinski CreditAttribution: askibinski at Merge commentedThanks for the patch 7gipsy! Tested and it works. Conmitted to -dev. I will also release an 1.3 version.
http://cgit.drupalcode.org/ckeditor_mentions/commit/?id=f03cbbc