Including login link in URL tokens

You can easily test this even in local dev environment; here are the instructions:

1. Install basic Commerce modules, including order and order UI
2. Install Devel module.
3. Install Maillog module. This will allow you to see the emails Drupal will try to send to users after completing the checkout.
4. Configure Maillog: /admin/config/development/maillog
   • Make sure the Display the e-mails on page using devel module (if enabled). option is checked.
   • Optionally uncheck
     

     Allow the e-mails to be sent<code> if you're working in dev environment.</li>
     </ul></li>
     <li>If you are testing this from a non-adminstrative account (e.g. regular or anonymous users), be sure to grant the permission to see developer information. This is necessary so you can immediately see the output of <code>dpm()

     function.

     • Go to: /admin/people/permissions
     • Grant Access developer information to anonymous and authenticated users
   • Add a product, create a test order and check out the new links displayed on the page and in order email. Do this as both - logged in and anonymous user.

Hope this helps anyone who wants to test this patch - let me know if you have any other questions.

Thanks!

Thanks for your messages guys.

I'll have a look at how does the patch behave with Login Destination and Login Toboggan.
In case there are some conflicts, I believe Mike's suggestion would be the most appropriate.

I'd just add maybe a notice for admins just so they know what's going on and that it's not a bug.

Will try this and keep this thread posted.

Sidenote - I noticed late that Drupal didn't like the formatting of my message; wrote it as markdown in Sublime text and then just copied as HTML :)

Just tested this with "Login Toboggan" and "Login Destination" modules.

TL;DR - patch still works fine.
Added a message for admins about potential conflict with "Login Destination" module, because it depends on how they configure it.

Long version

LoginToboggan

Redirections seem to be related only to registrations.
I assume that users who are trying to see their own orders will not try to register again, because their account has already been created.
If they do, they will go through the workflow that is out of the scope of Commerce and they anyways won't be able to see the order then.
I have not found any issues between this patch and LoginToboggan module.

Login Destination

There is an issue if the module is configured to redirect URLs that include "user/login" OR when the module ignores destination parameter in the query string.
I believe this is part of a bigger issue, which is inability of drupal_match_path() to match paths that include query string. In this case, the perfect solution would be to exclude *?destination=user/*/orders/* from Login Destination rules in order for this to work properly.

I added a notification message for administrators. It will appear on Commerce Order settings page only if the login_destination module is installed and if the destination parameter is ignored.
Also, a new checkbox has been added that will allow users to ignore the warning - in case they want to override this through a custom module or add user/login path to the list of excluded redirections.

Attached is the patch - thanks!