The language manager loads one language to find the storage to call listAll() on.

That's not necessary, we can just call it on the config factory(). Does save an unnecessary cache call.

CommentFileSizeAuthor
#1 improve-language-loading-2228129-1.patch837 bytesBerdir
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Title: Unecessary separate config load call to load languages » Unnecessary separate config load call to load languages
Status: Active » Needs review
FileSize
improve-language-loading-2228129-1.patch837 bytes

The patch.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented

Looks sensible to me

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed bb78e06 and pushed to 8.x. Thanks!

  • Commit bb78e06 on 8.x by alexpott: 
    Issue #2228129 by Berdir: Unnecessary separate config load call to load...
YesCT’s picture

YesCT CreditAttribution: YesCT commented

this patch changed the code, but not the comment about the code...
anyway, we dont want to use config. and want to use the entity system, so #2239497: [Meta] Fix ConfigurableLanguageManager getLanguages()

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.