just try to test this module. when tried to install, got broken site.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

h3rj4n’s picture

Status: Active » Needs review
Issue tags: -broken site feeds +Chasing HEAD: broken site feeds
FileSize
10.38 KB

I didn't have the error you've described but had a couple other ones. I've changed a couple of files so that the module at least can be enabled and your cache can be cleared.

What doesn't work:

  • Adding an importer

What was not tested:

  • Everything else
h3rj4n’s picture

Title: Installed this module got site broken » Chasing HEAD: Installed this module got site broken
Issue tags: -Chasing HEAD: broken site feeds
FileSize
28.49 KB

Update the code a little bit further:

  • getStorageController() to getStorage()
  • added libraries.yml file

It's still not possible to create a new feed item. Still some stuff that needs to be edited.

lalit774’s picture

FileSize
42.04 KB
38.59 KB

I got same error after patching.

h3rj4n’s picture

I'm not able to reproduce this. Everything still works for me (just checked out a fresh Drupal install). Are you using the latest dev version? So not a alpha release but the latest HEAD in the git repo? As I see it your missing the following commit:

* 3a5e997 Issue #2221065 by damiankloip, Wim Leers, Berdir: Rename default 'cache' cache bin to 'default'. - Nathaniel Catchpole, 4 days ago

lalit774’s picture

I used fresh install with drupal-8.0-alpha10 and feeds 8.x-3.x-dev.

h3rj4n’s picture

alpa-10 doesn't contain that patch yet. You should either checkout the git repo or wait for alpha-11 to come out.

Alpha-10 is 3 weeks old. Between alpha-10 and now are 250 commits. That are a lot of changes!

h3rj4n’s picture

FileSize
77.8 KB
55.1 KB

I removed a lot of depricated calls and a lot / all the changed class names.

It's still not fully functional.

MegaChriz’s picture

I think it would be wise to contact twistor to discuss in what direction he want to go with Feeds. If I remember well, the 8.x-3.x version of the module wasn't functional yet even with the Drupal 8 alpha that was the latest on February 6, 2014 (the date of the latest commit to the 8.x-3.x branch).

nicholas.alipaz’s picture

Seems release notes on both 8.x branches say not to use them.

andypost’s picture

It would be great to discus architecture for 8.x
There's one of suggestions #2300927: New architecture for new Drupal

The last submitted patch, 1: feeds-working_module-2228503.patch, failed testing.

The last submitted patch, 2: feeds-working_module-2228503-2.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 7: feeds-working_module-2228503-7.patch, failed testing.

twistor’s picture

Priority: Critical » Normal

As of this post, things are working, more-or-less.

I've been steadily at work. The port is done, but there are lots of changes that need/should happen.

If anybody has any ideas/suggestions, #2300927: New architecture for new Drupal is open and waiting.

twistor’s picture

davidseth’s picture

@twistor, what version of Drupal 8 are you using and what version of Feeds? I ask because I used Drupal 8 alpha 15 with latest git 8.x branch of Feeds and it breaks my Drupal 8 install.

Thanks,

David

twistor’s picture

Try beta-1 :) But, for future reference, I'm just following HEAD of Drupal core, not targeting any specific release. Now that there's a beta, it might make sense to start targeting a release. It's just a lot easier to pull once a day and make whatever changes are necessary rather than letting them accumulate.

MegaChriz’s picture

Status: Needs work » Closed (fixed)

I'm closing this issue since I think it's outdated. Most of the suggestions from the patch are now in the module. Further improvements can be handled in other issues.