Commerce Kickstart uses the returned transaction to create messages.

CommentFileSizeAuthor
#1 issue-2229901.patch466 byteslsolesen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lsolesen’s picture

lsolesen CreditAttribution: lsolesen commented
Status: Active » Needs review
FileSize
issue-2229901.patch466 bytes
bojanz’s picture

bojanz CreditAttribution: bojanz commented
Status: Needs review » Reviewed & tested by the community

Yep.

rszrama’s picture

rszrama CreditAttribution: rszrama commented

I may need a bit more info here; can you point me to where Commerce Kickstart is using this? I'm just not certain how this function having a return value will affect anything, when the function that calls it, commerce_payment_example_submit_form_submit(), doesn't return anything itself. Also, what does Kickstart do for all the other payment method modules out there that don't return a transaction?

lsolesen’s picture

lsolesen CreditAttribution: lsolesen commented

It is used during the installation of CK 2.x.

http://drupalcode.org/project/commerce_kickstart.git/blob/refs/heads/7.x...

@bojanz said that the example payment was based on the method originally added to kickstart, which also returned the transaction.

http://drupalcode.org/project/commerce_kickstart.git/blob/5f0c02f034d965...

rszrama’s picture

rszrama CreditAttribution: rszrama commented
Status: Reviewed & tested by the community » Fixed

Ahh, I see - so it doesn't really matter that no other payment gateway does this. I'll get it in.

  • Commit f4a852c on 7.x-1.x authored by lsolesen, committed by rszrama: 
    Issue #2229901 by lsolesen: return the payment transaction created by...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.