parameters to addMigration() and registerMigration() are confusing [#2229903]

protected function addMigration($machine_name, $class_name, $arguments

but:

  static public function registerMigration($class_name, $machine_name = NULL,
      array $arguments = array()) {

This is really painful to work with! I keep forgetting which way round the class name and machine name go, and since the values you pass in are pretty similar anyway, it's just makes for a really confusing time all round!

Comments

Comment #1

mikeryan

he/him

English

Murphysboro, IL, USA

CreditAttribution: mikeryan commented 8 April 2014 at 16:46

Title:	paramters to addMigration() and registerMigration() are confusing	» parameters to addMigration() and registerMigration() are confusing
Issue tags:		+Migrate 2.6

Good point - but it's tricky to make the change when migrate_d2d and wordpress_migrate are already using it. Timing is everything - perhaps committing the change to all three modules just before simultaneous new releases, and hope anyone using migrate_d2d and/or wordpress_migrate makes sure to update to all the new releases. Which still screws anyone building their own wizards (as you are) - the effect will be hard to debug... I'll think about it, not sure if it's worthwhile at this point.