Array to string conversion error when trying to add a new user

This is the notice you will receive when a new user is added.

Check if $value is an array and transform it to string using implode().

Patch seems to fix the issue properly.

Hm. We should be able to add a test that catches this. In fact, I'm mystified how existing tests are not catching this... adding a user from admin/people is not exactly the outer limits.

Just investigated why the UserCreateTest wasn't picking up the error, as on the face of it it should have been. It turns out it's because contact module isn't enabled in the test. Have added a patch which will pick up the error, not sure this is a change that needs to be committed.

To show test failing.

Worked out that the problem is being caused by contact_form_user_form_alter. The account_data default for the contact form is set as an array if their is no account id for the form (i.e. when there is an empty form). UserData->get returns the array which I assume is correct so I made a fix in the form_alter function.

I've left the 'contact' enabled in the usercreate simpletest to pick up the error. Wonder whether should write a new test for the contact module which checks that field, any thoughts?

hi

checked this one and if the change to the test is added without patch the test fails which is what we want.
When adding the patch it works as it is supposed to do and test passes.

I'm feeling lucky..I'm setting this to done..it does the job as far as I'm concerned..can't see any trouble with it

Committed 562adda and pushed to 8.x. Thanks!

This is a duplicate of #2030743: Improve tests for user form alters in contact module which has more far reaching tests :(

+++ b/core/modules/user/lib/Drupal/user/Tests/UserCreateTest.php
@@ -19,7 +19,7 @@ class UserCreateTest extends WebTestBase {
-  public static $modules = array('image');
+  public static $modules = array('image', 'contact');

#2030743: Improve tests for user form alters in contact module is going to undo this and add actual test coverage as webchick asked for.