flag_get_user_flag_counts() summerizes flags of all anonymous users

Hmm this makes sense but the problem is that it would be an API Change.

I agree that this rather seems to be a bug than a feature. While user 0 is technically a user, I can't think of a common use case where counting the flags of all anonymous users vs the current anonymous user is preferrable.
If the API change (and I agree that it is one, since it changes the function result) should turn out to be a blocker on this issue, maybe we can introduce a third argument like $count_anon_by_session (defaulting to false)?

Btw, patch works well for Flag 3.5 + 9 commits (revision c0f427e).

> Therefor it should deliver what is documented: "Get the user's flag count."
Currently it's like "Get the authenticated user's flag count or the sum of the flag counts of all anonymous users." That second one doesn't make sens

On the one hand, I see what you mean. On the other, 'the anonymous user', uid 0, is a single Drupal user, and so in that sense we are doing what the documentation says.

Thing is, we've no idea what people are using it for in their custom code.

I think the best way to tackle this is to add an optional parameter to the function, eg $use_anon_sid, so we don't change existing behaviour.

Hi All,

Please check attached patch with optional parameter to the function.

Thanks,
Gaurav

Attached wrong file.

Thanks for working on this. Looks pretty good, just a couple of things:

+++ b/flag.module
@@ -1770,20 +1770,22 @@ function flag_get_entity_flag_counts($flag, $entity_type) {
+function flag_get_user_flag_counts($flag, $user, $use_anon_sid = NULL) {

New param needs documentation.

Also, this is a boolean, so default should be FALSE.

Hi joachim,

Please find updated patch with given suggestions.

Thanks,
Gaurav