FieldConfig does not depend on the module the provides the entity type

+++ b/core/modules/field/tests/Drupal/field/Tests/FieldConfigEntityUnitTest.php
@@ -88,10 +84,34 @@ public function setUp() {
+    // Get definition is called three times. Twice in
+    // ConfigEntityBase::addDependency() to get the provider of the field config
+    // entity type and once in FieldConfig::calculateDependencies() to get the
+    // provider of the entity type that field is attached to.
+    $this->entityManager->expects($this->at(0))
+      ->method('getDefinition')
+      ->with($this->entityTypeId)
+      ->will($this->returnValue($fieldConfigentityType));
+    $this->entityManager->expects($this->at(1))
+      ->method('getDefinition')
+      ->with($this->entityTypeId)
+      ->will($this->returnValue($this->entityType));
+    $this->entityManager->expects($this->at(2))
+      ->method('getDefinition')
+      ->with($this->entityTypeId)
+      ->will($this->returnValue($fieldConfigentityType));

This is super-confusing. Can't we use two different entity type ID's if we need two different types? This doesn't seem like a realistic scenario, we could be calling it with the wrong ID or something?

Yes, now the test makes much more sense :)

I guess it would also be possible to solve getDefinition() with a $this->returnValueMap(), but the explicit expectations and explanation of calls is in this case is OK I think. (It sometimes is too strict and makes internal refactoring painful...)

Committed/pushed to 8.x, thanks!