Upgrading to 1.14 seems to break the custom search block form. Downgrading to 1.13 restores functionality. I did some code tracing comparison between the two versions, and noticed that in 1.14 the function custom_search_submit was not being called, whereas in 1.13 it was.

Any help would be appreciated.

Edit: Clarification on what I mean by broken. Submitting the search form with or without a search term appears to do nothing. The page just reloads. That's why I mentioned that the custom_search_submit was not called.

Comments

jdanthinne’s picture

jdanthinne CreditAttribution: jdanthinne commented
Status: Active » Postponed (maintainer needs more info)

What do you mean by broken? Visually? Content filtering? Taxonomy filtering? Results?…?

nelsonre’s picture

nelsonre CreditAttribution: nelsonre commented
Issue summary: View changes

Sorry about that. I've update the problem description.

nelsonre’s picture

nelsonre CreditAttribution: nelsonre commented
Status: Postponed (maintainer needs more info) » Active
jdanthinne’s picture

jdanthinne CreditAttribution: jdanthinne commented

Do you have a test url?

nelsonre’s picture

nelsonre CreditAttribution: nelsonre commented

Sorry, no publicly available test url.

I did get it to work by commenting out this line in custom_search_blocks.module
// $form['#action'] = url('search/node');

I hope that gives you an idea of what might be going on.

I figured out that none of my custom search paths were being used, so it appeared that the page was just reloading, but I think all my searches were going to search/node

jdanthinne’s picture

jdanthinne CreditAttribution: jdanthinne commented

Are you using custom search paths for those broken blocks?
The change you're talking about was introduced there : https://drupal.org/node/2140129 , but perhaps it was not the right solution…

mcunningham’s picture

mcunningham CreditAttribution: mcunningham commented

Same issue here...updated the module on my dev server (not internet accessible) and now all searches from custom search blocks simply lead to /search/node without passing any search terms or content type filters along.

[edit]: Oh and btw I am not using any custom search paths.

jdanthinne’s picture

jdanthinne CreditAttribution: jdanthinne commented

@mcunningham: have you tried #5?

nelsonre’s picture

nelsonre CreditAttribution: nelsonre commented

yes, I am using custom search paths. I have it set up with 5 search paths that are selectable using a radio box pop-up.

glkr’s picture

glkr CreditAttribution: glkr commented

1.14 update broke custom search block on my site too, instead of displaying search results, I get blank /search/node/ page. Unfortunately no test page available since I already downgraded back to 1.13.

jdanthinne’s picture

jdanthinne CreditAttribution: jdanthinne commented
Status: Active » Needs review

I reverted a recent change in the module, please try http://drupalcode.org/project/custom_search.git/patch/254a0c5

mcunningham’s picture

mcunningham CreditAttribution: mcunningham commented

Yes, #5 (which is the same as your patch) does resolve the issue. Thanks!

glkr’s picture

glkr CreditAttribution: glkr commented

#11 Patch fixed the block issue, thanks a lot!

mlit’s picture

mlit CreditAttribution: mlit commented

#5 resolves the issue. Thanks!

jdanthinne’s picture

jdanthinne CreditAttribution: jdanthinne commented
Status: Needs review » Closed (fixed)

Ok then, a stable release is planned for tomorrow.