Problem/Motivation

Views UI or other Ajax based loading did not work because of incorrect variable validation on load.

Proposed resolution

Fix the js for loading.

Remaining tasks

User interface changes

API changes

Original report by @mstef

Getting this on line 21 of the JS whenever using Views with nodes that contain an Addthis widget. Completely breaks the Views UI.

CommentFileSizeAuthor
#6 2233585-6.patch1.53 KBmatglas86
#3 2233585-3.patch1.35 KBmatglas86
#3 interdiff.txt1.01 KBmatglas86
#1 addthis_uncaught-typeerror-2233585-1.patch450 bytesmstef
#4 interdiff.txt707 bytesmatglas86
#4 2233585-4.patch1.53 KBmatglas86
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mstef’s picture

mstef CreditAttribution: mstef commented
Status: Active » Needs review
FileSize
addthis_uncaught-typeerror-2233585-1.patch450 bytes

I'm not great with JS but this works for me. Also not sure why this error would even be happening (maybe that should be looked in to instead).

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Status: Needs review » Reviewed & tested by the community
matglas86’s picture

matglas86 CreditAttribution: matglas86 commented
Issue summary: View changes
Status: Reviewed & tested by the community » Needs review
FileSize
2233585-3.patch1.35 KB
interdiff.txt1.01 KB

For me it did not fix the Views UI. The buttons where not rendered. Here is my renewed patch.

matglas86’s picture

matglas86 CreditAttribution: matglas86 commented
Related issues: +#1381470: Button not working on ajax pages
FileSize
2233585-4.patch1.53 KB
interdiff.txt707 bytes

My last patch did not work with a Views Block with ajax paging. I looked into it and found this solution. It works for toolbox and button widgets.

matglas86’s picture

matglas86 CreditAttribution: matglas86 commented

In a week I'll be merging this in. Please provide some feedback if there are still problems and describe the exactly the setup that does not work. Thanks!

matglas86’s picture

matglas86 CreditAttribution: matglas86 commented
FileSize
2233585-6.patch1.53 KB

I did a rerun against head.

matglas86’s picture

matglas86 CreditAttribution: matglas86 commented
Status: Needs review » Fixed

  • Commit ab1a8e5 on 7.x-4.x by matglas86: 
    Fixed issue #2233585 by matglas86, mstef: Uncaught TypeError: Object #...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.