Site theme overrides Nice Menu css [#2233777]

The Nice Menu css is loaded before the Drupal theme's css. This causes the menu to display unexpectedly as shown in the picture:

skewed menu

I found if I changed the drupal_add_css() calls in _load_nice_menus_library() to use the CSS_THEME group instead of the CSS_DEFAULT group that the css would load after the Drupal theme's css and that the problem is resolved.

This is how things should look:

correct display

Are others not experiencing this issue? I cannot see anything unusual about my site (unless nobody else uses Garland theme though I saw the same issue in Bartik theme as well).

I would be happy to produce a patch for the change I made but if there is a better way to fix this, please help me see how.

Thanks!

Comment	File	Size	Author
	correct.png	1.62 KB	wdouglascampbell
	problem.png	1.64 KB	wdouglascampbell

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

wdouglascampbell CreditAttribution: wdouglascampbell commented 17 April 2014 at 01:59

I was hoping someone else might comment on this issue. I realize now that my suggested fix may not be the best approach as it would change the expected formatting of the main Drupal theme. While it may make my nice menu now look good, it could on some sites cause other page elements to display in a non-optimal way.

Any thoughts? What might be the best approach then to fix this so that the change would be incorporated into the official module?

Comment #2

wdouglascampbell CreditAttribution: wdouglascampbell commented 28 April 2014 at 22:22

Okay. Instead of my previous approach, I am wondering if the following might be better.

If I change the nice_menus_default.css for the following:

ul.nice-menu,
ul.nice-menu ul {
  list-style: none;
  padding: 0;
  margin: 0;
  border-top: 1px solid #ccc;
}

to:

.block-nice-menus ul.nice-menu,
ul.nice-menu ul {
  list-style: none;
  padding: 0;
  margin: 0;
  border-top: 1px solid #ccc;
}

it resolves the issue as well. I am thinking this should only affect nice menu blocks and no other.

Thoughts?

Comment #3

ramesh_singh CreditAttribution: ramesh_singh at SDG Corporation commented 3 July 2017 at 10:51

you just change the code in nice_menus_default.CSS file

ul.nice-menu-down {
 /*float: left; *//* LTR */
  border: 0;
}

don't comment border property.

and also change in theme which you use for eg: i use bartik theme then goes to bartik/css/style.css

.sidebar h2 {
  margin: 0 0 0.5em;
  /* border-bottom: 1px solid #d6d6d6; */
  padding-bottom: 5px;
  text-shadow: 0 1px 0 #fff;
  font-size: 1.071em;
  line-height: 1.2;
}

comment the border-bottom section.
thanks