Off the island front enders more generally call the site header the "masthead".

What's termed the menu-bar in AT is more commonly referred to as a "navbar" also.

I'm going to make this semantic changes, as they're not only more universal but differentiate from the UI widget "a menu bar", and make it clear which header we're talking about, since we have header element and it can be used in many places - lets just call it masthead and everyone knows what this is.

Comments

Jeff Burnz’s picture

Status: Active » Fixed

Fix in yml files, next is a simply refresh of the sample page template and the fix is complete, marking as fixed.

Adds id masthead to the header row.
Changes menubar to navbar.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

benjarlett’s picture

I reckon you need to change the page.html.twig file too... it still has menubar in it... I changed the lines 30 onwards to this and the nav bar appeared....

 {% if navbar__regions.active == true %}
  <div{{ navbar__attributes }}>
    <div class="regions">
      {{ page.navbar }}
    </div>
  </div>
  {% endif %}
benjarlett’s picture

Status: Closed (fixed) » Needs review
Jeff Burnz’s picture

yeah, you are right, I did change it, however now I am going to get rid of all special cased rows and regions. I have modified the system significantly with regards to menus and navbar-ish things so that any region can act as the wrapper to responsive menus, so we don't need to special case the CSS or JS based on a region or row class hook.

Jeff Burnz’s picture

Status: Needs review » Closed (fixed)

I kept the nav bar region and generalised the Responsive menu system, it all works well now.