Do not add role IDs

I have an issue with the line

$roles[] = $context->data->uid ? DRUPAL_AUTHENTICATED_RID : DRUPAL_ANONYMOUS_RID;

in ctools_role_ctools_access_check

of

plugins/access/role.inc

This line adds the current user's system role to the roles that are retrieved from the context.

However, in my limited testing these roles already were present für authenticated and anonymous users.

Why is that a problem?

It clashes with logintoboggans "pre-auth" role feature which removes the DRUPAL_AUTHENTICATED_RID from users that haven't confirmed their email yet.

Now if you want to show a panel to users that have confirmed their email but not those that haven't, you have a problem.

I propose to remove that line.